From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Mike Hommey" <mh@glandium.org>,
"brian m . carlson" <sandals@crustytoothpaste.net>,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Glen Choo" <chooglen@google.com>,
"Eric DeCosta" <edecosta@mathworks.com>
Subject: Re: [PATCH] Makefile: use sha1collisiondetection by default on OSX and Darwin
Date: Thu, 20 Oct 2022 16:26:56 -0700 [thread overview]
Message-ID: <xmqq4jvyqdof.fsf@gitster.g> (raw)
In-Reply-To: <patch-1.1-1f4e39be97b-20221020T225305Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Fri, 21 Oct 2022 01:01:20 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Junio: I see in the meantime you've queued your own
> https://lore.kernel.org/git/cover-v3-0.9-00000000000-20221020T223946Z-avarab@gmail.com/;
> which is currently in "seen".
Yes, as I said, I intend to merge it to 'next' in tomorrow's
pushout, and then fast track all three topics (Peff's "-O0",
Eric/Ævar's "use git_SHA_CTX abstraction", and "osx-clan uses
sha1dc") down to 'master'. As you chose to make this topic hostage
to the other multi-part topic, which is likely to be slowed down and
require rerolls for typofixes and possible bikeshedding, by the time
this topic becomes ready, it is likely that it would already be in
'master' and you'd have to rebase on that.
Isn't this step of much higher importance than the other multi-part
topic? I do not see why you chose to take it a hostage to the other
one. Let's all learn to give priorities to produce sufficiently
focused fixes that also sufficiently cover important issues. Frills
and niceties can come on top later.
next prev parent reply other threads:[~2022-10-20 23:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 23:01 [PATCH] Makefile: use sha1collisiondetection by default on OSX and Darwin Ævar Arnfjörð Bjarmason
2022-10-20 23:26 ` Junio C Hamano [this message]
2022-10-20 23:52 ` Ævar Arnfjörð Bjarmason
2022-12-15 8:43 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2022-12-15 21:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq4jvyqdof.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=carenas@gmail.com \
--cc=chooglen@google.com \
--cc=edecosta@mathworks.com \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).