From: Junio C Hamano <gitster@pobox.com>
To: "Jakub Narębski" <jnareb@gmail.com>
Cc: Andreas Brauchli <a.brauchli@elementarea.net>, git@vger.kernel.org
Subject: Re: [PATCH] gitweb: escape link body in format_ref_marker
Date: Mon, 01 Aug 2016 12:54:13 -0700 [thread overview]
Message-ID: <xmqq37mojme2.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <51785fbd-6858-c9b2-7f59-eaf7bd3ea394@gmail.com> ("Jakub Narębski"'s message of "Sat, 30 Jul 2016 19:46:39 +0200")
Jakub Narębski <jnareb@gmail.com> writes:
> Good catch!
>
> Acked-by: Jakub Narębski <jnareb@gmail.com>
Sigh; the contents may be good but the patch is unusable as-is
because of heavy whitespace damage.
I'll fix it up. Thanks, both.
>> ---
>> gitweb/gitweb.perl | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
>> index 2fddf75..33d701d 100755
>> --- a/gitweb/gitweb.perl
>> +++ b/gitweb/gitweb.perl
>> @@ -2090,7 +2090,7 @@ sub format_ref_marker {
>> -href => href(
>> action=>$dest_action,
>> hash=>$dest
>> - )}, $name);
>> + )}, esc_html($name));
>>
>> $markers .= " <span
>> class=\"".esc_attr($class)."\" title=\"".esc_attr($ref)."\">" .
>> $link . "</span>";
>>
next prev parent reply other threads:[~2016-08-01 20:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 14:49 [PATCH] gitweb: escape link body in format_ref_marker Andreas Brauchli
2016-07-30 17:46 ` Jakub Narębski
2016-08-01 19:54 ` Junio C Hamano [this message]
2016-08-02 10:25 ` Andreas Brauchli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq37mojme2.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=a.brauchli@elementarea.net \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).