From: Junio C Hamano <gitster@pobox.com>
To: Rich Felker <dalias@libc.org>
Cc: James B <jamesbond3142@gmail.com>,
musl@lists.openwall.com,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jeff King <peff@peff.net>,
git@vger.kernel.org
Subject: Re: [musl] Re: Regression: git no longer works with musl libc's regex impl
Date: Tue, 04 Oct 2016 15:48:37 -0700 [thread overview]
Message-ID: <xmqq37kbspbu.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161004223322.GE19318@brightrain.aerifal.cx> (Rich Felker's message of "Tue, 4 Oct 2016 18:33:22 -0400")
Rich Felker <dalias@libc.org> writes:
> This is especially unfriendly when the semantics of the switch come
> across, at least to some users, as "your system regex is incomplete"
> rather than "git can't use it because git depends on nonstandard
> extensions".
The latter is exactly what Makefile patch that brought this change
says, I think.
# Define NO_REGEX if your C library lacks regex support with REG_STARTEND
# feature.
Before the series updated the message to the above, we used to say:
# Define NO_REGEX if you have no or inferior regex support in your C library.
which _was_ unfair to those who needed to set NO_REGEX for whatever
reason. It was totally unclear "inferior" relative to what standard
the message was passing its harsh judgement on your C library.
next prev parent reply other threads:[~2016-10-04 22:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 15:08 Regression: git no longer works with musl libc's regex impl Rich Felker
2016-10-04 15:27 ` Jeff King
2016-10-04 15:40 ` Rich Felker
2016-10-04 16:08 ` Johannes Schindelin
2016-10-04 16:11 ` Rich Felker
2016-10-04 17:16 ` Johannes Schindelin
2016-10-04 18:00 ` Ray Donnelly
2016-10-04 17:39 ` [musl] " Rich Felker
2016-10-05 11:17 ` Johannes Schindelin
2016-10-05 13:01 ` Szabolcs Nagy
2016-10-05 13:15 ` Rich Felker
2016-10-04 22:06 ` James B
2016-10-04 22:33 ` Rich Felker
2016-10-04 22:48 ` Junio C Hamano [this message]
2016-10-05 13:11 ` Jakub Narębski
2016-10-05 16:15 ` [musl] " Rich Felker
2016-10-05 10:41 ` Johannes Schindelin
2016-10-05 11:59 ` James B
2016-10-05 16:11 ` Jeff King
2016-10-05 16:27 ` Rich Felker
2016-10-06 10:44 ` Johannes Schindelin
2016-10-06 19:18 ` Ævar Arnfjörð Bjarmason
2016-10-06 19:23 ` Jeff King
2016-10-06 19:25 ` Rich Felker
2016-10-06 19:28 ` Jeff King
2016-10-06 22:42 ` Ramsay Jones
2016-10-07 11:30 ` Jakub Narębski
2016-10-04 16:01 ` Johannes Schindelin
-- strict thread matches above, loose matches on Subject: below --
2016-10-05 3:00 [musl] " writeonce
2016-10-05 10:49 ` Johannes Schindelin
2016-10-05 16:37 writeonce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq37kbspbu.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=dalias@libc.org \
--cc=git@vger.kernel.org \
--cc=jamesbond3142@gmail.com \
--cc=musl@lists.openwall.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).