From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <johannes.schindelin@gmx.de>
Cc: git@vger.kernel.org, Pranit Bauva <pranit.bauva@gmail.com>,
Johannes Sixt <j6t@kdbg.org>, Beat Bolli <dev+git@drbeat.li>
Subject: Re: [PATCH v2 0/3] Really fix the isatty() problem on Windows
Date: Thu, 22 Dec 2016 10:19:26 -0800 [thread overview]
Message-ID: <xmqq37hfhln5.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqqd1gjhn0u.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Thu, 22 Dec 2016 09:49:37 -0800")
Junio C Hamano <gitster@pobox.com> writes:
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> ...
>> - fixed the confusing commit message by using Junio's suggested
>> replacement
>
> Sorry, but I didn't mean to "suggest replacement". I was just
> testing my understanding by attempt to rephrase the gist of it.
> ...
> Your "use this opportunity to actually clean up" above suggests that
> the answer is the latter, but if you took my "summary of my
> understanding", it is likely that that fact is not captured in the
> resulting log message.
So using the original log message in v1 and what you wrote in the
message I was responding to as references, let me try a real
"suggested" one as penance.
I need to ask one clarification on what you wrote before completing
that effort, though.
>> And incidentally, replacing the previous hack with the clean, new
>> solution, which specifies explicitly for the file descriptors 0, 1 and 2
>> whether we detected an MSYS2 pseudo-tty, whether we detected a real
>> Win32 Console, and whether we had to swap out a real Win32 Console for a
>> pipe to allow child processes to inherit it.
This has subject but not verb. I parsed the above like so:
Replacing the previous hack with the clean, new solution (which
specifies explicitly for the file descriptors 0, 1 and 2
- whether we detected an MSYS2 pseudo-tty,
- whether we detected a real Win32 Console, and
- whether we had to swap out a real Win32 Console for a
pipe to allow child processes to inherit it
)
So the entire thing is a noun phrase "replacing with a new patch",
and I take that as the subject of an unfinished sentence. What did
that subject do? Replacing with a new patch allows us to do "this
wonderful thing", but what "this wonderful thing" is not clear.
Subject: mingw: replace isatty() hack
From: Jeff Hostetler <jeffhost@microsoft.com>
For over a year, Git for Windows has carried a patch that detects
the MSYS2 pseudo ttys used by Git for Windows' default Git Bash
(i.e. a terminal that is not backed by a Win32 Console), but it did
so by accessing internals of a previous MSVC runtime that is no
longer valid in newer versions.
Clean up this mess by backporting a patch that was originally done
to compile Git with a recent VC++. Replacing the previous hack with
the clean, new solution, which specifies explicitly for the file
descriptors 0, 1 and 2 whether we detected an MSYS2 pseudo-tty,
whether we detected a real Win32 Console, and whether we had to swap
out a real Win32 Console for a pipe to allow child processes to
inherit it, lets us do XXXXX.
As a side effect (which was the reason for the back-port), this patch
also fixes the previous misguided attempt to intercept isatty() so that
it handles character devices (such as /dev/null) as Git expects it.
next prev parent reply other threads:[~2016-12-22 18:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 17:53 [PATCH 0/2] Really fix the isatty() problem on Windows Johannes Schindelin
2016-12-21 17:53 ` [PATCH 1/2] mingw: adjust is_console() to work with stdin Johannes Schindelin
2016-12-21 17:53 ` [PATCH 2/2] mingw: replace isatty() hack Johannes Schindelin
2016-12-21 18:45 ` Junio C Hamano
2016-12-21 21:15 ` [PATCH 0/2] Really fix the isatty() problem on Windows Johannes Sixt
2016-12-21 21:21 ` Junio C Hamano
2016-12-22 18:48 ` Johannes Sixt
2016-12-22 21:33 ` Johannes Schindelin
2016-12-22 17:08 ` [PATCH v2 0/3] " Johannes Schindelin
2016-12-22 17:08 ` [PATCH v2 1/3] mingw: adjust is_console() to work with stdin Johannes Schindelin
2016-12-22 23:04 ` Beat Bolli
2016-12-22 23:18 ` Junio C Hamano
2016-12-23 9:30 ` Johannes Schindelin
2016-12-23 12:51 ` Beat Bolli
2016-12-22 17:09 ` [PATCH v2 2/3] mingw: fix colourization on Cygwin pseudo terminals Johannes Schindelin
2016-12-22 17:09 ` [PATCH v2 3/3] mingw: replace isatty() hack Johannes Schindelin
2016-12-22 20:26 ` Johannes Sixt
2016-12-22 21:37 ` Johannes Schindelin
2016-12-22 22:28 ` Johannes Sixt
2016-12-22 23:18 ` Johannes Schindelin
2016-12-22 17:49 ` [PATCH v2 0/3] Really fix the isatty() problem on Windows Junio C Hamano
2016-12-22 17:59 ` Johannes Schindelin
2016-12-22 18:32 ` Junio C Hamano
2016-12-22 18:19 ` Junio C Hamano [this message]
2016-12-22 23:16 ` [PATCH v3 " Johannes Schindelin
2016-12-22 23:16 ` [PATCH v3 1/3] mingw: adjust is_console() to work with stdin Johannes Schindelin
2016-12-22 23:16 ` [PATCH v3 2/3] mingw: fix colourization on Cygwin pseudo terminals Johannes Schindelin
2016-12-22 23:16 ` [PATCH v3 3/3] mingw: replace isatty() hack Johannes Schindelin
2017-01-18 12:13 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq37hfhln5.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=dev+git@drbeat.li \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=johannes.schindelin@gmx.de \
--cc=pranit.bauva@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).