git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Quentin Pradet <quentin.pradet@gmail.com>
Cc: git@vger.kernel.org,
	Antoine Delaite <antoine.delaite@ensimag.grenoble-inp.fr>
Subject: Re: [PATCH] git-bisect.txt: add missing word
Date: Sat, 01 Apr 2017 11:34:21 -0700	[thread overview]
Message-ID: <xmqq37dsugcy.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170401064056.56969-1-quentin.pradet@gmail.com> (Quentin Pradet's message of "Sat, 1 Apr 2017 10:40:56 +0400")

Quentin Pradet <quentin.pradet@gmail.com> writes:

> Signed-off-by: Quentin Pradet <quentin.pradet@gmail.com>
> ---
>  Documentation/git-bisect.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

The updated text is more grammatically correct.  It would have been
better if you avoided wrapping the lines unnecessarily, though.

Thanks.

> diff --git a/Documentation/git-bisect.txt b/Documentation/git-bisect.txt
> index bdd915a66..90148bb07 100644
> --- a/Documentation/git-bisect.txt
> +++ b/Documentation/git-bisect.txt
> @@ -137,9 +137,9 @@ respectively, in place of "good" and "bad". (But note that you cannot
>  mix "good" and "bad" with "old" and "new" in a single session.)
>  
>  In this more general usage, you provide `git bisect` with a "new"
> -commit has some property and an "old" commit that doesn't have that
> -property. Each time `git bisect` checks out a commit, you test if that
> -commit has the property. If it does, mark the commit as "new";
> +commit that has some property and an "old" commit that doesn't have
> +that property. Each time `git bisect` checks out a commit, you test if
> +that commit has the property. If it does, mark the commit as "new";
>  otherwise, mark it as "old". When the bisection is done, `git bisect`
>  will report which commit introduced the property.

      reply	other threads:[~2017-04-01 18:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01  6:40 [PATCH] git-bisect.txt: add missing word Quentin Pradet
2017-04-01 18:34 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq37dsugcy.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=antoine.delaite@ensimag.grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=quentin.pradet@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).