From: Junio C Hamano <gitster@pobox.com> To: Dennis Kaarsemaker <dennis@kaarsemaker.net> Cc: git@vger.kernel.org, avarab@gmail.com, Eric Biggers <ebiggers3@gmail.com> Subject: Re: [PATCH v2] send-email: Net::SMTP::SSL is obsolete, use only when necessary Date: Thu, 01 Jun 2017 07:50:06 +0900 Message-ID: <xmqq37bkabfl.fsf@gitster.mtv.corp.google.com> (raw) In-Reply-To: <1495227246.19473.3.camel@kaarsemaker.net> Dennis Kaarsemaker <dennis@kaarsemaker.net> writes: > Second ping. This problem is not going away, so if this solution is not > acceptable, I'd like to know what needs to be improved. Perhaps you needed to actually test with older installation that people have, it seems, between pings. Immediately after this was merged to 'master', we start getting bug reports X-<. Eric Biggers' message https://public-inbox.org/git/<20170531222455.GD72735@gmail.com> seems to indicate that we should cut off at 3.01 not 1.28? Thanks. > On Thu, 2017-05-04 at 09:01 +0200, Dennis Kaarsemaker wrote: >> Ping. It's a little over a month since I sent this, but I haven't seen >> any comments. Is this commit good to go? >> >> On Fri, 2017-03-24 at 22:37 +0100, Dennis Kaarsemaker wrote: >> > Net::SMTP itself can do the necessary SSL and STARTTLS bits just fine >> > since version 1.28, and Net::SMTP::SSL is now deprecated. Since 1.28 >> > isn't that old yet, keep the old code in place and use it when >> > necessary. >> > ... >> > diff --git a/git-send-email.perl b/git-send-email.perl >> > index eea0a517f7..0d90439d9a 100755 >> > --- a/git-send-email.perl >> > +++ b/git-send-email.perl >> > @@ -1353,10 +1353,12 @@ EOF >> > die __("The required SMTP server is not properly defined.") >> > } >> > >> > + require Net::SMTP; >> > + my $use_net_smtp_ssl = version->parse($Net::SMTP::VERSION) < version->parse("1.28");
next prev parent reply index Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-20 21:18 [PATCH] Remove dependency on deprecated Net::SMTP::SSL Mike Fisher 2016-11-20 21:53 ` brian m. carlson 2017-01-13 14:59 ` Renato Botelho 2016-11-21 5:37 ` Torsten Bögershausen 2017-03-18 22:23 ` [PATCH] send-email: Net::SMTP::SSL is obsolete, use only when necessary Dennis Kaarsemaker 2017-03-18 22:47 ` Ævar Arnfjörð Bjarmason 2017-03-18 23:14 ` Dennis Kaarsemaker 2017-03-24 21:37 ` [PATCH v2] " Dennis Kaarsemaker 2017-05-04 7:01 ` Dennis Kaarsemaker 2017-05-19 20:54 ` Dennis Kaarsemaker 2017-05-20 7:56 ` Ævar Arnfjörð Bjarmason 2017-05-31 22:50 ` Junio C Hamano [this message] 2017-06-01 19:42 ` Dennis Kaarsemaker 2017-05-31 21:46 ` Jonathan Nieder 2017-05-31 22:39 ` Junio C Hamano 2017-05-31 22:53 ` Jonathan Nieder
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=xmqq37bkabfl.fsf@gitster.mtv.corp.google.com \ --to=gitster@pobox.com \ --cc=avarab@gmail.com \ --cc=dennis@kaarsemaker.net \ --cc=ebiggers3@gmail.com \ --cc=git@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
git@vger.kernel.org mailing list mirror (one of many) Archives are clonable: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.org/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ or Tor2web: https://www.tor2web.org/ AGPL code for this site: git clone https://public-inbox.org/ public-inbox