From: Junio C Hamano <gitster@pobox.com>
To: Michael J Gruber <git@grubix.eu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/2] Documentation/git-for-each-ref: clarify peeling of tags for --format
Date: Fri, 18 Aug 2017 09:53:42 -0700 [thread overview]
Message-ID: <xmqq378oddgp.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <45e7986107a8e8b2f87891c729be8e13043670f3.1503067851.git.git@grubix.eu> (Michael J. Gruber's message of "Fri, 18 Aug 2017 16:51:23 +0200")
Michael J Gruber <git@grubix.eu> writes:
> `*` in format strings means peeling of tag objects so that object field
> names refer to the object that the tag object points at, instead of the
> tag object itself.
>
> Currently, this is documented using grammar that is clearly inspired by
> classical latin, though missing more than an article in order to be
> classical english.
;-)
Thanks, both patches look good to me.
>
> Try and straighten that explanation out a bit.
>
> Signed-off-by: Michael J Gruber <git@grubix.eu>
> ---
> Documentation/git-for-each-ref.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-for-each-ref.txt b/Documentation/git-for-each-ref.txt
> index dac9138fab..bb370c9c7b 100644
> --- a/Documentation/git-for-each-ref.txt
> +++ b/Documentation/git-for-each-ref.txt
> @@ -41,8 +41,9 @@ OPTIONS
> A string that interpolates `%(fieldname)` from a ref being shown
> and the object it points at. If `fieldname`
> is prefixed with an asterisk (`*`) and the ref points
> - at a tag object, the value for the field in the object
> - tag refers is used. When unspecified, defaults to
> + at a tag object, use the value for the field in the object
> + which the tag object refers to (instead of the field in the tag object).
> + When unspecified, `<format>` defaults to
> `%(objectname) SPC %(objecttype) TAB %(refname)`.
> It also interpolates `%%` to `%`, and `%xx` where `xx`
> are hex digits interpolates to character with hex code
prev parent reply other threads:[~2017-08-18 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 14:51 [PATCH 1/2] Documentation: use proper wording for ref format strings Michael J Gruber
2017-08-18 14:51 ` [PATCH 2/2] Documentation/git-for-each-ref: clarify peeling of tags for --format Michael J Gruber
2017-08-18 16:53 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq378oddgp.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@grubix.eu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).