From: Junio C Hamano <gitster@pobox.com>
To: Stephan Beyer <s-beyer@gmx.net>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v2] Add a comment to .clang-format about the meaning of the file
Date: Mon, 02 Oct 2017 05:30:59 +0900 [thread overview]
Message-ID: <xmqq3772vce4.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171001154425.5568-1-s-beyer@gmx.net> (Stephan Beyer's message of "Sun, 1 Oct 2017 17:44:25 +0200")
Stephan Beyer <s-beyer@gmx.net> writes:
> Having a .clang-format file in a project can be understood in a way that code
> has to be in the style defined by the .clang-format file, i.e., you just have
> to run clang-format over all code and you are set. This is not the case in the
> Git project, which is now reflected by a comment in the beginning of the file.
>
> Additionally, the working clang-format version is mentioned because the config
> directives change from time to time (in a compatibility-breaking way).
>
> Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
> ---
>
> Notes:
> On 10/01/2017 04:45 AM, Junio C Hamano wrote:
> > it makes as if a random patch to "make it
> > conform" without thinking if the rules make sense were a welcome
> > addition, which is absolutely the last signal we would want to send
> > to the readers.
>
> Right. I dropped that last sentence and replaced it by a sentence about human
> aesthetics judgement overruling mechanical rules -- I think that's somehow quoted
> from a comment of yours on the list.
Sorry, but that is not what I meant.
I think we do want the endgame to be that .clang-format defines how
the code should look like. It's that we are not there yet, and I
think that is what we should say in this comment.
Note that this style definition does not yet quite reflect
how we want our code to look like, and adjusting the rules
to match our style is still work in progress. Do not
blindly adjust the style of _existing_ code, without
checking if the code is styled incorrectly, or the style
definition in this file is still wrong.
is what I should have suggested when writing my response.
next prev parent reply other threads:[~2017-10-01 20:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 18:26 [PATCH] clang-format: adjust line break penalties Johannes Schindelin
2017-09-29 18:40 ` Jonathan Nieder
2017-09-29 19:50 ` Brandon Williams
2017-09-29 22:39 ` Stephan Beyer
2017-09-29 22:45 ` Jonathan Nieder
2017-09-30 21:37 ` [PATCH] Add a comment to .clang-format about the meaning of the file Stephan Beyer
2017-10-01 2:45 ` Junio C Hamano
2017-10-01 15:44 ` [PATCH v2] " Stephan Beyer
2017-10-01 20:30 ` Junio C Hamano [this message]
2017-10-01 21:29 ` Stephan Beyer
2017-10-01 23:37 ` [PATCH v3] clang-format: add a comment about the meaning/status of the Junio C Hamano
2017-10-02 17:16 ` Stephan Beyer
2017-10-02 17:21 ` Brandon Williams
2017-10-03 1:08 ` Ramsay Jones
2017-10-01 2:40 ` [PATCH] clang-format: adjust line break penalties Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq3772vce4.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=jrnieder@gmail.com \
--cc=s-beyer@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).