git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: git@vger.kernel.org,
	Christian Couder <christian.couder@gmail.com>,
	Jeff King <peff@peff.net>, Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCH] diff: add tests for --relative without optional prefix value
Date: Thu, 07 Dec 2017 11:17:36 -0800	[thread overview]
Message-ID: <xmqq374me4a7.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171207190135.28660-1-jacob.e.keller@intel.com> (Jacob Keller's message of "Thu, 7 Dec 2017 11:01:35 -0800")

Jacob Keller <jacob.e.keller@intel.com> writes:

>  for type in diff numstat stat raw; do
> -	check_$type file2 --relative=subdir/
> -	check_$type file2 --relative=subdir
> -	check_$type dir/file2 --relative=sub
> +	check_$type . file2 --relative=subdir/
> +	check_$type . file2 --relative=subdir
> +	check_$type . dir/file2 --relative=sub
> +	check_$type subdir file2 --relative

OK, I didn't think it would be sensible to unconditionally pass the
directory and use "-C ." as a no-op.  It looks good.

I think the new one should go before the dir/file2 test; all three
earlier tests (including this new one) are about taking a patch
relative to subdir/ spelled in different ways, and the one about
dir/file2 alone is different.

  reply	other threads:[~2017-12-07 19:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 19:01 [PATCH] diff: add tests for --relative without optional prefix value Jacob Keller
2017-12-07 19:17 ` Junio C Hamano [this message]
2017-12-07 19:54   ` Jacob Keller
2017-12-07 21:12 ` Jeff King
2017-12-07 21:20   ` Jacob Keller
2017-12-07 21:50   ` Junio C Hamano
2017-12-07 22:05     ` Jacob Keller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq374me4a7.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jacob.keller@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).