git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: 林自均 <johnlinp@gmail.com>
Cc: John Lin via GitGitGadget <gitgitgadget@gmail.com>,
	Git <git@vger.kernel.org>
Subject: Re: [PATCH 1/1] status: remove the empty line after hints
Date: Tue, 28 May 2019 13:40:47 -0700	[thread overview]
Message-ID: <xmqq36ky1fe8.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAKO26MsGpEcK74CSdgNGjFdKAMDP5Knm+0_vtcnrBBJjBfjcQA@mail.gmail.com> ("林自均"'s message of "Tue, 28 May 2019 15:42:32 +0800")

林自均 <johnlinp@gmail.com> writes:

> Hi Junio,
>
> John Lin via GitGitGadget <gitgitgadget@gmail.com> 於 2019年5月15日 週三 下午6:54寫道:
>>
>> From: John Lin <johnlinp@gmail.com>
>>
>> Before this patch, there is inconsistency between the status
>> messages with hints and the ones without hints: there is an
>> empty line between the title and the file list if hints are
>> presented, but there isn't one if there are no hints.
>>
>> This patch remove the inconsistency by removing the empty
>> lines even if hints are presented.
>
> I would like to ask for the final decision on this patch. Thank you.

If I recall correctly, the test part of this patch conflicts badly
with a topic in flight that splits 'checkout' into 'restore' and
'switch', which is a more important topic between the two.  So if I
must give _the final_ decision, then we need to drop this patch, but
I'd rather not ;-)

Doing this change on top of the switch/restore topic, once it
stabilized more and graduated to 'master', would be the best course
of action, I would think.

Thanks.

  reply	other threads:[~2019-05-28 20:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 10:54 [PATCH 0/1] status: remove the empty line after hints John Lin via GitGitGadget
2019-05-15 10:54 ` [PATCH 1/1] " John Lin via GitGitGadget
2019-05-28  7:42   ` 林自均
2019-05-28 20:40     ` Junio C Hamano [this message]
2019-05-28 23:08       ` 林自均
2019-05-29 11:51         ` Johannes Schindelin
2019-06-01  1:12           ` 林自均
2019-06-03 14:17             ` Johannes Schindelin
2019-06-03 15:06               ` 林自均
2019-06-04 13:37                 ` Johannes Schindelin
2019-06-04 14:02 ` [PATCH v2 0/1] " John Lin via GitGitGadget
2019-06-04 14:02   ` [PATCH v2 1/1] " John Lin via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq36ky1fe8.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johnlinp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).