From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Matheus Tavares Bernardino <matheus.bernardino@usp.br>,
git <git@vger.kernel.org>, Jeff King <peff@peff.net>,
Derrick Stolee <dstolee@microsoft.com>,
Elijah Newren <newren@gmail.com>, Taylor Blau <me@ttaylorr.com>
Subject: Re: git-grep in sparse checkout
Date: Wed, 02 Oct 2019 15:18:29 +0900 [thread overview]
Message-ID: <xmqq36gbfz62.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <f3101c8f-9709-5bcb-35f0-39ffaf8aa809@gmail.com> (Derrick Stolee's message of "Tue, 1 Oct 2019 14:29:00 -0400")
Derrick Stolee <stolee@gmail.com> writes:
> Is that the expected behavior? In a sparse-checkout, wouldn't you _want_
> Git to report things outside the cone?
That should be optional, I would think. When you declare "by
default, this the subset of the project I am interested in", we
should honor it, I would think.
> At minimum, I would expect a new option to have "git grep" go back to
> the old behavior, so users who really want a tree-wide search can have
> one.
Yeah, a bugfix to honor SKIP_WORKTREE bit, followed by a new feature
to ignore it, would be pretty sensible way to go.
next prev parent reply other threads:[~2019-10-02 6:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 13:06 git-grep in sparse checkout Matheus Tavares Bernardino
2019-10-01 13:30 ` Bert Wesarg
2019-10-01 16:12 ` Elijah Newren
2019-10-02 6:33 ` Junio C Hamano
2019-10-02 16:46 ` Elijah Newren
2019-10-01 18:29 ` Derrick Stolee
2019-10-02 0:06 ` Matheus Tavares Bernardino
2019-10-02 6:18 ` Junio C Hamano [this message]
2019-10-02 12:09 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq36gbfz62.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=matheus.bernardino@usp.br \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).