git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Denton Liu <liu.denton@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Dec 2019, #01; Mon, 2)
Date: Tue, 03 Dec 2019 08:34:52 -0800	[thread overview]
Message-ID: <xmqq36e174gj.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191202210534.GA49785@generichostname> (Denton Liu's message of "Mon, 2 Dec 2019 13:05:34 -0800")

Denton Liu <liu.denton@gmail.com> writes:

> vague commit messages from the first round of review. Note that 4/5 has
> a spurious change that should be removed ...

Which was exactly why I did not pick up the last posted one.  In
general, I would not pick up a series when the author is aware of an
issue to be fixed, and more importantly, when the author knows how
to fix that issue.  That way, I do not have to be as intimate with
the issue-and-fix as the author and the reviewer, who came up with
it in their exchange.  That way we can avoid unnecessary mistakes,
trying pick up the latest one and making an incorrect tweak that is
different from what the author and the reviewer agreed to be the
good way forward.

It's a different story when that reviewer is me, of course---in that
corner case, I should be just as familiar with the final issue as
the author would be, so it may save time without risking mixups for
me to add the final finishing touches myself.


  reply	other threads:[~2019-12-03 16:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 14:16 What's cooking in git.git (Dec 2019, #01; Mon, 2) Junio C Hamano
2019-12-02 15:59 ` Elijah Newren
2019-12-02 21:05 ` Denton Liu
2019-12-03 16:34   ` Junio C Hamano [this message]
2019-12-03 16:38   ` Junio C Hamano
2019-12-04  6:19     ` Denton Liu
2019-12-04 18:14       ` Junio C Hamano
2019-12-04 18:53 ` Derrick Stolee
2019-12-06 21:31   ` Junio C Hamano
2019-12-13 13:38 ` Ed Maste
2019-12-13 13:58   ` Ed Maste
2019-12-13 19:02     ` Junio C Hamano
2019-12-16  2:26 ` Heba Waly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq36e174gj.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=liu.denton@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).