From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: Adam Milazzo <Adam.Milazzo@microsoft.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [EXTERNAL] Re: BUG: git clean -d cannot remove files from read-only directories
Date: Thu, 20 Feb 2020 17:48:40 -0800 [thread overview]
Message-ID: <xmqq36b490cn.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CABPp-BFwNMTRUUonbt3Di8yWDjyF7n2cNQVoLDfHEsk3RVEchQ@mail.gmail.com> (Elijah Newren's message of "Thu, 20 Feb 2020 15:13:33 -0800")
Elijah Newren <newren@gmail.com> writes:
> should be and what it should do. Your "put the repository back to a
> pristine state" isn't enough to really go on from an implementation.
Yeah, where does this "pristine state" come from? Do we need to fix
the "git clean" documentation to reduce such a confusion (I didn't
check to see if the current text is prone to be misunderstood as
such yet). "git clean" is to remove crufts, isn't it? The
definition of "cruft" being untracked junk that are marked
expendable (aka "ignored")? And it is not "remove crurfts no matter
what".
> angle from my previous response in what you've addressed here. Let's
> say we did implement a new flag that said we should override standard
> permissions. In such a case, shouldn't ACLs also be overridden? ...
> what point do we give up? What's the clear line...and why does that
> line not just get drawn at not changing permissions at all?
Yup. Elsewhere in the thread you gave "rm -fr" not removing an
unwritable subdirectory, and that shows where others before us drew
the line that has been accepted by the end users.
> I'm sympathetic to "golang does a dumb thing I don't like" (the exact
> situation you hilight has bothered me before too), but it's not clear
> at all to me where or how git might help you cope with that. To me,
> golang did a dumb and you have to manually undo the dumb. If you want
> something smarter on the git side instead of the golang side, all the
> stuff I mentioned above are things that would need to be addressed in
> any possible solution that I'm just not seeing.
Amen.
next prev parent reply other threads:[~2020-02-21 1:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 18:55 BUG: git clean -d cannot remove files from read-only directories Adam Milazzo
2020-02-20 19:45 ` Elijah Newren
2020-02-20 20:05 ` [EXTERNAL] " Adam Milazzo
2020-02-20 22:26 ` Junio C Hamano
2020-02-20 23:52 ` Adam Milazzo
2020-02-21 0:42 ` Elijah Newren
2020-02-20 23:13 ` Elijah Newren
2020-02-21 1:48 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-21 0:52 Adam Milazzo
2020-02-21 1:08 ` Elijah Newren
2020-02-21 3:06 ` [EXTERNAL] " Adam Milazzo
2020-02-21 5:38 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq36b490cn.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=Adam.Milazzo@microsoft.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).