git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: git@vger.kernel.org,
	"Dr . Matthias St . Pierre" <Matthias.St.Pierre@ncp-e.com>,
	Stefan Beller <stefanbeller@gmail.com>,
	"Dr . Matthias St . Pierre" <m.st.pierre@ncp-e.com>
Subject: Re: [PATCH v2 2/2] blame: document --color-* options
Date: Wed, 29 Sep 2021 12:15:29 -0700	[thread overview]
Message-ID: <xmqq35pndwha.fsf@gitster.g> (raw)
In-Reply-To: <20210929124935.41917-3-bagasdotme@gmail.com> (Bagas Sanjaya's message of "Wed, 29 Sep 2021 19:49:35 +0700")

Bagas Sanjaya <bagasdotme@gmail.com> writes:

> Commit cdc2d5f11f1a (builtin/blame: dim uninteresting metadata lines,
> 2018-04-23) and 25d5f52901f0 (builtin/blame: highlight recently changed
> lines, 2018-04-23) introduce --color-lines and --color-by-age options to
> git blame, respectively. While both options are mentioned in usage help,
> they aren't documented in git-blame(1). Document them.
>
> Co-authored-by: Dr. Matthias St. Pierre <m.st.pierre@ncp-e.com>
> Signed-off-by: Dr. Matthias St. Pierre <m.st.pierre@ncp-e.com>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
>  Documentation/blame-options.txt | 12 ++++++++++++
>  Documentation/config/color.txt  | 12 ++++++------
>  Documentation/git-blame.txt     |  4 ++--
>  3 files changed, 20 insertions(+), 8 deletions(-)

Nicely written.

> +--color-lines::
> +	Color lines differently, if they belong to the same commit as the preceding line.

Is "belong" the right verb?  I view these lines "come from" their
originating commits, so "they belong to" -> "they come from",
perhaps.

>  color.blame.repeatedLines::
> -	Use the customized color for the part of git-blame output that
> -	is repeated meta information per line (such as commit id,
> -	author name, date and timezone). Defaults to cyan.
> +	Use the specified color to colorize line annotations, if they belong to the

Ditto.

Thanks.

      reply	other threads:[~2021-09-29 19:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 12:49 [PATCH v2 0/2] blame: documentation update Bagas Sanjaya
2021-09-29 12:49 ` [PATCH v2 1/2] blame: Describe default output format Bagas Sanjaya
2021-09-29 19:11   ` Junio C Hamano
2021-09-29 12:49 ` [PATCH v2 2/2] blame: document --color-* options Bagas Sanjaya
2021-09-29 19:15   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq35pndwha.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Matthias.St.Pierre@ncp-e.com \
    --cc=bagasdotme@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=m.st.pierre@ncp-e.com \
    --cc=stefanbeller@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).