From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id E9A941F953 for ; Thu, 16 Dec 2021 22:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233945AbhLPW1H (ORCPT ); Thu, 16 Dec 2021 17:27:07 -0500 Received: from pb-smtp20.pobox.com ([173.228.157.52]:56987 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230462AbhLPW1G (ORCPT ); Thu, 16 Dec 2021 17:27:06 -0500 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 1687B162209; Thu, 16 Dec 2021 17:27:06 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=PLggtgm1AEMt XKvgW2jw7NqYCivsbZVaO8PE9GgX/yQ=; b=SlojI51/BsUnmdGOncN7CLRUrLQl rPUlZgbx7a/4hLUPpggMJk+M15aDraJGkC7jN4itoT+lkNq94ANtHCorCUKHapZm 72N/6R7NnPtRL5UuvX+8ZI1JL7acrae+d166l4fCpI75t6HQ8dACc7vWT/T4Tt/b FlZga8YY5FUkXIE= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 0FD60162208; Thu, 16 Dec 2021 17:27:06 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 6F3FB162206; Thu, 16 Dec 2021 17:27:02 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Han-Wen Nienhuys , Bagas Sanjaya Subject: Re: [PATCH v2 0/9] reftable prep: have builtin/reflog.c handle "--verbose" References: Date: Thu, 16 Dec 2021 14:27:01 -0800 In-Reply-To: (=?utf-8?B?IsOGdmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Thu, 16 Dec 2021 14:45:09 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 4A956B44-5EBF-11EC-9912-C85A9F429DF0-77302942!pb-smtp20.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > This series refactors various small bits of builtin/reflog.c > (e.g. using a "struct string_list" now), and finally makes it handle > the "--verbose" output, instead of telling the files backend to emit > that same verbose output. I was quite confused even after spending quite some time until I realized that you are primarily talking about the "-v" option of "git reflog expire" (and "delete", perhaps) and not about "git reflog -v" having different output from the same command without "-v" option. I'll refrain from commenting on, or picking up, the series until Han-Wen has a chance to take a look and give his input as it is unclear if it helps or crashes with his plan.