From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Lars Kellogg-Stedman <lars@oddbit.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] line-range: Fix infinite loop bug with degenerate regex
Date: Wed, 07 Dec 2022 14:29:50 +0900 [thread overview]
Message-ID: <xmqq359r7pdd.fsf@gitster.g> (raw)
In-Reply-To: <221207.86tu27aju3.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Wed, 07 Dec 2022 05:52:04 +0100")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> It's perfectly OK to provide a zero-width regex in general, e.g. try:
> Or for a non-git tool:
> ...
The same story goes for "^" or even ".*", I suspect.
> I think the real bug here is that we are pointing our regexec() at the
> haystack of multiple lines as an optimization.
>
> Then in "determine extent of line matched" and "is it a funcname line"
> assuming that a positive match must be non-zero-width. But that's just
> because the optimization is leaky.
Good thinking.
next prev parent reply other threads:[~2022-12-07 5:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-05 19:36 [PATCH v2] line-range: Fix infinite loop bug with degenerate regex Lars Kellogg-Stedman
2022-12-07 4:33 ` Eric Sunshine
2022-12-07 4:52 ` Ævar Arnfjörð Bjarmason
2022-12-07 5:29 ` Junio C Hamano [this message]
2022-12-07 20:30 ` SZEDER Gábor
2022-12-09 19:16 ` Lars Kellogg-Stedman
2022-12-11 1:53 ` [PATCH v3] line-range: Fix infinite loop bug with degenerate '$' regex Lars Kellogg-Stedman
2022-12-11 3:32 ` Junio C Hamano
2022-12-11 3:34 ` Junio C Hamano
2022-12-14 14:53 ` Lars Kellogg-Stedman
2022-12-18 1:33 ` Junio C Hamano
2022-12-19 22:48 ` [PATCH v4] line-range: fix infinite loop bug with " Lars Kellogg-Stedman
2022-12-19 22:55 ` Ævar Arnfjörð Bjarmason
2022-12-20 0:00 ` Eric Sunshine
2022-12-20 1:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq359r7pdd.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=lars@oddbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).