From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.6 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [IPv6:2604:1380:4601:e00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 5CF621F44D for ; Fri, 19 Apr 2024 19:16:31 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.a=rsa-sha256 header.s=sasl header.b=tpyVm8EQ; dkim-atps=neutral Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C43331F223D1 for ; Fri, 19 Apr 2024 19:16:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E6AB813C8E5; Fri, 19 Apr 2024 19:16:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b="tpyVm8EQ" Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41E4A77F13 for ; Fri, 19 Apr 2024 19:16:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=64.147.108.70 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713554180; cv=none; b=ILs33uzu2eHwqiNbbFiW7rCYlNwydTzc+hP6cg0wXgwMBCNE8upHmsTT5QgB7sVFWw/f9y5c5ANGUHIi2zXeo2WrPAamKlK6vNZfoDS3KYjecGAsjdGVgQ+tiepj3Y0DIJN3FFtI3E5f7fm/vW2e1F+6XtJYGe5gBj8UXrf0660= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713554180; c=relaxed/simple; bh=mWQKavsKKc3ckFLQxb+U75nU9XOfTtknqGmHkXObw30=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=WbGeq8pVJw3Ko5I+29+ekMxS8M5D81zllBE4ihI+WgO22gjz/n8EmnKn4uAN3p2f3o0hjhel2/kzOzIUNXvj2v9Q0PFogZs2jgPmhA+VEeTXBv+WlDElXBGJikgndpYGw80Q+AmZ92X3PT5U+pn7EY8U+76sMq/6JezKMsqHnqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (1024-bit key) header.d=pobox.com header.i=@pobox.com header.b=tpyVm8EQ; arc=none smtp.client-ip=64.147.108.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id DBD9F1F5132; Fri, 19 Apr 2024 15:16:17 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=mWQKavsKKc3ckFLQxb+U75nU9XOfTtknqGmHkX Obw30=; b=tpyVm8EQGmUzXcGt/tb9oRQ1zWiZECuPWIGeKeG/UeOmMvE3bn6bdA zCnW6++INdDaxPrHu/Pz1NCA39BAYyhgbkIlpijQGtN0nWQuq316qCqYoyQ9igpY 7svhdorhWypOxelPaSIjOt7oKyzwGXfVHyC2f6SYOsxLjSmqSiYys= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id D40B51F5131; Fri, 19 Apr 2024 15:16:17 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.125.120.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 3FC091F5130; Fri, 19 Apr 2024 15:16:17 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "brian m. carlson" Cc: Patrick Steinhardt , git@vger.kernel.org Subject: Re: [PATCH 00/11] Stop relying on SHA1 fallback for `the_hash_algo` In-Reply-To: (brian m. carlson's message of "Fri, 19 Apr 2024 19:12:59 +0000") References: Date: Fri, 19 Apr 2024 12:16:16 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 4BE79422-FE81-11EE-9275-78DCEB2EC81B-77302942!pb-smtp1.pobox.com "brian m. carlson" writes: > I've taken a look, and other than the minor typo I noted, this seems > fine. I'm in favour of getting rid of the SHA-1 default, even though my > gut tells me we might find a bug or two along the way where things > aren't initialized properly. I still think that'll be okay and it's > worth doing, since it'll help us prepare for the case in the future > where we want to switch the default and also for libification, where we > won't want to make those kinds of assumptions. Yup, thanks for reviewing (and thanks Patrick for writing the series).