From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Sudhanshu Shekhar <sudshekhar02@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] reset: allow "-" short hand for previous commit
Date: Tue, 03 Mar 2015 15:17:53 -0800 [thread overview]
Message-ID: <xmqq1tl5acwu.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpq4mq13f69.fsf@anie.imag.fr> (Matthieu Moy's message of "Tue, 03 Mar 2015 23:10:54 +0100")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Sudhanshu Shekhar <sudshekhar02@gmail.com> writes:
>
>> From: SudShekhar <sudshekhar02@gmail.com>
>
> Please, set your configuration to have the same identity for commit and
> send-email. It seems your commiter ID (user.name) does not contain your
> last name.
Actually, the token does not match either of the two names; it looks
like two names smashed together into a single nickname token.
>> builtin/reset.c | 2 ++
>
> Doesn't this deserve a test?
>
> + if(!strcmp(argv[0],"-"))
> + argv[0]="@{-1}";
>
> Wrong spacing (around = and after ,).
What should worry us even more is what the user would get when @{-1}
does not resolve to something the command can use. It would be bad
if we give an error message with @{-1} in it that the user never
typed (and may not even understand what it means).
next prev parent reply other threads:[~2015-03-03 23:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 20:51 [PATCH] reset: allow "-" short hand for previous commit Sudhanshu Shekhar
2015-03-03 22:10 ` Matthieu Moy
2015-03-03 23:17 ` Junio C Hamano [this message]
2015-03-04 7:07 ` Sudhanshu Shekhar
2015-03-04 7:09 ` Sudhanshu Shekhar
2015-03-04 7:10 ` Eric Sunshine
2015-03-05 0:34 ` Junio C Hamano
2015-03-07 21:04 ` [PATCH 1/2] " Sudhanshu Shekhar
2015-03-08 10:33 ` Matthieu Moy
2015-03-08 14:58 ` [PATCH 1/2] Teach reset the same short-hand as checkout Sudhanshu Shekhar
2015-03-08 14:58 ` [PATCH 2/2] Added test cases for git reset - Sudhanshu Shekhar
2015-03-08 18:09 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tl5acwu.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=sudshekhar02@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).