From: Junio C Hamano <gitster@pobox.com>
To: David Turner <dturner@twopensource.com>
Cc: git@vger.kernel.org, mhagger@alum.mit.edu
Subject: Re: [PATCH v4 0/6] refs backend preamble
Date: Sat, 27 Jun 2015 11:44:12 -0700 [thread overview]
Message-ID: <xmqq1tgxf0ub.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1435379036-30894-1-git-send-email-dturner@twopensource.com> (David Turner's message of "Sat, 27 Jun 2015 00:23:50 -0400")
David Turner <dturner@twopensource.com> writes:
> This version addresses Junio's comments on v3.
The end result makes more sense than the previous one, but did you
screw up when rewriting and/or squashing patches around the new 4/6?
I think that one has two separate changes mixed into one and does a
lot more than "this is just for clarity". I think they should stay
separate, as the other changes are more impactful and deserve their
own justification and explanation.
Thanks.
prev parent reply other threads:[~2015-06-27 18:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-27 4:23 [PATCH v4 0/6] refs backend preamble David Turner
2015-06-27 4:23 ` [PATCH v4 1/6] refs.c: add err arguments to reflog functions David Turner
2015-06-27 4:23 ` [PATCH v4 2/6] cherry-pick: treat CHERRY_PICK_HEAD and REVERT_HEAD as refs David Turner
2015-06-27 4:23 ` [PATCH v4 3/6] bisect: treat BISECT_HEAD as a ref David Turner
2015-06-27 4:23 ` [PATCH v4 4/6] refs: Break out check for reflog autocreation David Turner
2015-06-27 4:23 ` [PATCH v4 5/6] git-reflog: add create and exists functions David Turner
2015-06-27 4:23 ` [PATCH v4 6/6] git-stash: use git-reflog instead of creating files David Turner
2015-06-27 18:44 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1tgxf0ub.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).