From: Junio C Hamano <gitster@pobox.com>
To: Andreas Krey <a.krey@gmx.de>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH v2] commit: make --only --allow-empty work without paths
Date: Thu, 08 Dec 2016 08:47:06 -0800 [thread overview]
Message-ID: <xmqq1sxiv051.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161208135029.GA16292@inner.h.apk.li> (Andreas Krey's message of "Thu, 8 Dec 2016 14:50:29 +0100")
Andreas Krey <a.krey@gmx.de> writes:
> Ok, I've removed the clever message, as Junio suggested.
> I don't know what else to do to make it acceptable. :-)
> We're going to deploy it internally anyway, but I think
> it belongs in git.git as well (aka 'Can I has "will queue"?').
Oh, sorry for being unclear. Before I started saying "Slightly
related topic.", after quoting "The patch itself looks good to me."
by Peff, I meant to say "Yeah, this looks good; thanks.", but
apparently I forgot.
Removal of "Clever" is a separate issue and it may make sense to do
so, but it deserves its own commit with its own justification.
Sorry for making you send an extra round; let's queue the original,
and if you still are interested, have the "Clever" removal as its
own patch.
Thanks.
next prev parent reply other threads:[~2016-12-08 16:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 22:15 [PATCH] commit: make --only --allow-empty work without paths Andreas Krey
2016-12-03 4:32 ` Jeff King
2016-12-03 6:59 ` Andreas Krey
2016-12-03 16:23 ` Jeff King
2016-12-05 20:36 ` Junio C Hamano
2016-12-06 9:39 ` Andreas Krey
2016-12-05 20:52 ` Junio C Hamano
2016-12-08 13:50 ` [PATCH v2] " Andreas Krey
2016-12-08 16:47 ` Junio C Hamano [this message]
2016-12-09 4:10 ` [PATCH] commit: remove 'Clever' message for --only --amend Andreas Krey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1sxiv051.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=a.krey@gmx.de \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).