git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin/: add UNLEAKs
Date: Mon, 02 Oct 2017 13:07:26 +0900	[thread overview]
Message-ID: <xmqq1smmqjk1.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171001174208.1693753-1-martin.agren@gmail.com> ("Martin Ågren"'s message of "Sun, 1 Oct 2017 19:42:08 +0200")

Martin Ågren <martin.agren@gmail.com> writes:

> ... While addressing `msg` in builtin/tag.c, convert the existing
> `strbuf_release()` calls as well.

That part of this patch made me raise eyebrows a bit but only
slightly.  We are about to leave the function to exit anyway, and
all the other that got new UNLEAK(var) at the end are doing the same
thing.

So overall I think this patch makes sense.  Thanks.

  reply	other threads:[~2017-10-02  4:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-01 17:42 [PATCH] builtin/: add UNLEAKs Martin Ågren
2017-10-02  4:07 ` Junio C Hamano [this message]
2017-10-02  6:25 ` Jeff King
2017-10-02 10:20   ` Martin Ågren
2017-10-03  6:20     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1smmqjk1.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=martin.agren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).