From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 1/1] Introduce git add --renormalize .
Date: Fri, 10 Nov 2017 09:22:10 +0900 [thread overview]
Message-ID: <xmqq1sl7j83x.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20171109184700.GA27635@tor.lan> ("Torsten Bögershausen"'s message of "Thu, 9 Nov 2017 19:47:01 +0100")
Torsten Bögershausen <tboegi@web.de> writes:
> Here is a somwhat shorter description:
>
> Apply the "clean" process freshly to all tracked files.
> This is useful after changing `core.autocrlf` or the `text`
> attributes in the `.gitattributes` file because
> Git may not consider these files as changed.
I think it is OK to omit .git/config for brevity (I am assuming that
your justification is because you thought it was obvious it is a
configuration variable); but then it is equally obvious (if not
more) that `text` attribute comes from .gitattributes (notice we do
not mention core.autocrlf is a configuration variable in the above,
but we do say `text` is an attribute) so it can also be omitted for
brevity.
> Correct the files that had been commited with CRLF,
> they will from now on have LF instead.
Reading this as a single sentence immediately after the above
paragraph leaves me feel confused. First of all, this would not
happen unless the user corrects core.autocrlf/text like described
above. In fact, updating these settings is done as in order to do
that correction. So I'd say it should not be split.
> Re-run what the `clean` filter does.
This again looks out of place just like the previous sentence. In
fact, provided if "the clean process" is understood by the end user,
this is redundant.
> This option implies `-u`.
Taking these altogether, perhaps
Apply the "clean" process freshly to all tracked files to
forcibly add them again to the index. This is useful after
changing `core.autocrlf` configuration or the `text` attribute
in order to correct files added with wrong CRLF/LF line endings.
This option implies `-u`.
Thanks.
next prev parent reply other threads:[~2017-11-10 0:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 15:00 Line ending normalization doesn't work as expected Robert Dailey
2017-10-03 16:26 ` Torsten Bögershausen
2017-10-03 17:23 ` Robert Dailey
2017-10-03 19:19 ` Torsten Bögershausen
2017-10-04 2:00 ` Junio C Hamano
2017-10-04 16:26 ` Robert Dailey
2017-10-04 16:59 ` Jonathan Nieder
2017-10-04 18:03 ` Robert Dailey
2017-10-05 1:31 ` Junio C Hamano
2017-10-05 1:46 ` Jonathan Nieder
2017-10-04 21:17 ` Torsten Bögershausen
2017-10-05 1:38 ` Junio C Hamano
2017-10-05 3:31 ` Junio C Hamano
2017-10-05 21:42 ` Torsten Bögershausen
2017-10-06 0:33 ` Junio C Hamano
2017-10-06 17:58 ` Torsten Bögershausen
2017-10-16 16:49 ` [PATCH v1 1/1] Introduce git add --renormalize tboegi
2017-10-16 17:34 ` Junio C Hamano
2017-10-30 16:29 ` [PATCH v2 " tboegi
2017-11-07 5:50 ` Junio C Hamano
2017-11-07 17:26 ` Torsten Bögershausen
2017-11-08 0:37 ` Junio C Hamano
2017-11-09 18:47 ` Torsten Bögershausen
2017-11-10 0:22 ` Junio C Hamano [this message]
2017-11-12 20:08 ` Torsten Bögershausen
2017-11-16 16:38 ` [PATCH v3 " tboegi
2017-11-17 1:24 ` Junio C Hamano
2017-11-17 20:44 ` Eric Sunshine
2017-11-18 1:47 ` Junio C Hamano
2018-02-15 15:24 ` Line ending normalization doesn't work as expected Robert Dailey
2018-02-15 19:16 ` Junio C Hamano
2018-02-15 21:47 ` Robert Dailey
2018-02-16 16:34 ` Torsten Bögershausen
2018-02-16 17:19 ` Robert Dailey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1sl7j83x.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).