From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: John Cheng <johnlicheng@gmail.com>, git@vger.kernel.org
Subject: Re: Misleading documentation for git-diff-files (diff-filter)
Date: Thu, 04 Jan 2018 11:09:22 -0800 [thread overview]
Message-ID: <xmqq1sj5fnkt.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20180104164941.GB18376@sigill.intra.peff.net> (Jeff King's message of "Thu, 4 Jan 2018 11:49:42 -0500")
Jeff King <peff@peff.net> writes:
> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
> index 9d1586b956..743af97b06 100644
> --- a/Documentation/diff-options.txt
> +++ b/Documentation/diff-options.txt
> @@ -469,6 +469,12 @@ ifndef::git-format-patch[]
> +
> Also, these upper-case letters can be downcased to exclude. E.g.
> `--diff-filter=ad` excludes added and deleted paths.
> ++
> +Note that not all diffs can feature all types. For instance, diffs
> +from the index to the working tree can never have Added entries
> +(because the set of paths included in the diff is limited by what is in
> +the index). Similarly, copied and renamed entries cannot appear if
> +detection for those types is disabled.
Makes sense; thanks.
next prev parent reply other threads:[~2018-01-04 19:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-03 16:07 Misleading documentation for git-diff-files (diff-filter) John Cheng
2018-01-03 23:53 ` Junio C Hamano
2018-01-04 15:53 ` John Cheng
2018-01-04 16:49 ` Jeff King
2018-01-04 19:09 ` Junio C Hamano [this message]
2018-01-04 19:11 ` John Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1sj5fnkt.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johnlicheng@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).