From: Junio C Hamano <gitster@pobox.com>
To: Masaya Suzuki <masayasuzuki@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] pack-protocol.txt: accept error packets in any context
Date: Thu, 29 Nov 2018 16:49:08 +0900 [thread overview]
Message-ID: <xmqq1s74nx1n.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <xmqqh8g3t7gm.fsf@gitster-ct.c.googlers.com> (Junio C. Hamano's message of "Tue, 27 Nov 2018 14:28:25 +0900")
Junio C Hamano <gitster@pobox.com> writes:
>> diff --git a/connect.c b/connect.c
>> index 24281b608..458906e60 100644
>> --- a/connect.c
>> +++ b/connect.c
>> @@ -306,8 +306,6 @@ struct ref **get_remote_heads(struct packet_reader *reader,
>> die_initial_contact(1);
>> case PACKET_READ_NORMAL:
>> len = reader->pktlen;
>> - if (len > 4 && skip_prefix(reader->line, "ERR ", &arg))
>> - die(_("remote error: %s"), arg);
>> break;
>> case PACKET_READ_FLUSH:
>> state = EXPECTING_DONE;
This breaks build by not removing the decl of arg while removing the
last user of that variable in the function.
connect.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/connect.c b/connect.c
index 458906e60d..4813f005ab 100644
--- a/connect.c
+++ b/connect.c
@@ -296,7 +296,6 @@ struct ref **get_remote_heads(struct packet_reader *reader,
struct ref **orig_list = list;
int len = 0;
enum get_remote_heads_state state = EXPECTING_FIRST_REF;
- const char *arg;
*list = NULL;
--
2.20.0-rc1-10-g7068cbc4ab
next prev parent reply other threads:[~2018-11-29 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 4:53 [PATCH] pack-protocol.txt: accept error packets in any context Masaya Suzuki
2018-11-27 5:28 ` Junio C Hamano
2018-11-29 7:49 ` Junio C Hamano [this message]
2018-11-29 8:42 ` Junio C Hamano
2018-11-29 16:10 ` Masaya Suzuki
2018-11-30 1:39 ` Junio C Hamano
2018-12-03 23:59 ` Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1s74nx1n.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=masayasuzuki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).