From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Derrick Stolee" <dstolee@microsoft.com>
Subject: Re: Preparing for 2.20.1 brown-paper-bag maintenance release
Date: Fri, 14 Dec 2018 11:40:12 +0900 [thread overview]
Message-ID: <xmqq1s6kesqb.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CACsJy8CexGXtyBa1oNP0jVx-+8JPTcfTd5wf1ZyfJWf8HDtLVQ@mail.gmail.com> (Duy Nguyen's message of "Thu, 13 Dec 2018 19:17:49 +0100")
Duy Nguyen <pclouds@gmail.com> writes:
> On Thu, Dec 13, 2018 at 7:08 PM Duy Nguyen <pclouds@gmail.com> wrote:
>> There's also a bug in my patch (-2 is already being used by
>> parse_opt_unknown_cb and my patch will change behavior of git-blame at
>> least in theory).
>
> Ah no. Too many magic numbers in parse-options.c code. It's working
> fine but I'll need to give these some names to avoid confusion in the
> future.
OK.
prev parent reply other threads:[~2018-12-14 2:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 6:29 Preparing for 2.20.1 brown-paper-bag maintenance release Junio C Hamano
2018-12-13 12:50 ` Johannes Schindelin
2018-12-13 14:05 ` Ævar Arnfjörð Bjarmason
2018-12-13 18:08 ` Duy Nguyen
2018-12-13 18:17 ` Duy Nguyen
2018-12-14 2:40 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1s6kesqb.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).