mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Paul Mackerras <>
Cc: Denton Liu <>,
	Git Mailing List <>
Subject: Re: [PATCH] gitk: use --pretty=reference for copysummary
Date: Wed, 11 Dec 2019 14:05:13 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20191211215826.GA31614@blackberry> (Paul Mackerras's message of "Thu, 12 Dec 2019 08:58:26 +1100")

Paul Mackerras <> writes:

> On Wed, Dec 11, 2019 at 01:39:50PM -0800, Denton Liu wrote:
>> In an earlier commit[1], git learned the 'reference' pretty format.
>> Update copysummary to use this pretty format instead of manually
>> reimplementing it as a format string.
>> With this change, we lose the double-quotes surrounding the commit
>> subject but it seems the consensus is that the unquoted form is used
>> more often anyway[2] so this change should be acceptable.
>> Since gitk and git are usually packaged and distributed together, their
>> versions should be in sync so we should not have to worry a newer gitk
>> running on top of an older version of git that doesn't support the
>> 'reference' pretty format.
> In fact my policy is not to do this (introduce a change to gitk that
> means it requires the very latest git).  I would want the code either
> to test the git version (which the code already does in other places)
> or handle failure gracefully and fall back to the old command.

For a case like this one, the policy would mean that a single liner
patch like this will never be accepted, right?  After all, the code
that would be used as a fallback for older Git is very simple so it
is almost pointless to add a check for feature with conditional.
We can just use the fallback code always, which is essentially to
keep the current code.

It is a tangent, but arguably the current code is easier to extend.
I can even see somebody arguing for adding a gitk.summaryformat
configuration variable, whose value would default to "%h (%s, %ad)"
when missing---that can be quite straightforward to do without
Denton's patch.

So I dunno.

  reply	other threads:[~2019-12-11 22:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 21:39 [PATCH] gitk: use --pretty=reference for copysummary Denton Liu
2019-12-11 21:58 ` Paul Mackerras
2019-12-11 22:05   ` Junio C Hamano [this message]
2019-12-13  0:44 ` [PATCH v2 0/2] gitk: match Git's 'reference' pretty format Denton Liu
2019-12-13  0:44   ` [PATCH v2 1/2] gitk: drop quotes in copysummary format Denton Liu
2019-12-13 17:12     ` Junio C Hamano
2019-12-15  4:19     ` Paul Mackerras
2019-12-13  0:44   ` [PATCH v2 2/2] gitk: rename "commit summary" to "commit reference" Denton Liu
2019-12-13 17:12     ` Junio C Hamano
2019-12-15  4:36     ` Paul Mackerras
2019-12-13 17:04   ` [PATCH v2 0/2] gitk: match Git's 'reference' pretty format Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).