git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>,
	Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: Fetching 24 Linux commits = 1.2 GiB
Date: Wed, 15 Apr 2020 08:08:17 -0700	[thread overview]
Message-ID: <xmqq1roo947y.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200415135627.vx75hsphbpmgrquv@chatter.i7.local> (Konstantin Ryabitsev's message of "Wed, 15 Apr 2020 09:56:27 -0400")

Do these (and I think we saw other reports) make us rethink the
status of protocol v2 as the default?  Are all of these fallouts 
we saw so far easy-to-fix bugs, or are there more fundamental issues
in the v2 protocol design?

Thanks.

Konstantin Ryabitsev <konstantin@linuxfoundation.org> writes:

> On Wed, Apr 15, 2020 at 10:01:46AM +0200, Jiri Slaby wrote:
>> Hi,
>> 
>> I was at 8f3d9f354286 of:
>> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>> 
>> I did git remote update today and it fetched:
>> Receiving objects: 100% (7330823/7330823), 1.20 GiB
>> It updated master: 8f3d9f354286..8632e9b5645b, that is 24 small commits.
>> 
>> One colleague of mine fetched 1324 commits:
>> Receiving objects: 100% (6820/6820), 4.21 MiB | 6.70 MiB/s, done.
>> Resolving deltas: 100% (5114/5114), completed with 1035 local objects.
>> From git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux
>>    7e63420847ae..8632e9b5645b  master     -> origin/master
>> 
>> Another colleague fetched the same what I and:
>>   Receiving objects: 100% (7330823/7330823), 1.20 GiB
>> too.
>> 
>> I did git gc --prune && git prune now and I am at 1.7G back from 3.5 G.
>> 
>> Is that a bug? What info should I provide?
>
> I've helped sfr troubleshoot the same issue last week -- it's most 
> likely due to 2.26 turning on protocol version=2 by default.  
> Unfortunately, reproducing this has been tricky, so if you can reliably 
> make this happen again, then providing a full copy of your local tree as 
> well as the remote you're trying to fetch may greatly help narrow it 
> down.
>
> With sfr (for whom fetching 1.2G from .au is a bit of a big deal), we 
> solved it by forcing protocol.version=1.
>
> -K

  reply	other threads:[~2020-04-15 15:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15  8:01 Fetching 24 Linux commits = 1.2 GiB Jiri Slaby
2020-04-15  8:11 ` Andreas Schwab
2020-04-15  8:16   ` Jiri Slaby
2020-04-15  8:23     ` Andreas Schwab
2020-04-15  8:27       ` Jiri Slaby
2020-04-15  8:34         ` Andreas Schwab
2020-04-15 10:52 ` Kevin Daudt
2020-04-15 13:56 ` Konstantin Ryabitsev
2020-04-15 15:08   ` Junio C Hamano [this message]
2020-04-15 15:16     ` Jeff King
2020-04-15 18:52     ` Jonathan Nieder
2020-05-20  8:53     ` Andreas Schwab
2020-05-20  8:57       ` Andreas Schwab
2020-05-20 10:05       ` Michal Suchánek
2020-05-20 10:34         ` Andreas Schwab
2020-05-20 19:40       ` Jeff King
2020-05-25 18:22         ` Lukas Wunner
2020-05-25 18:37           ` Junio C Hamano
2020-04-16  6:31   ` Jiri Slaby
2020-04-21 10:02     ` Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1roo947y.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).