git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Hariom verma <hariom18599@gmail.com>
Cc: git <git@vger.kernel.org>,
	Eric Sunshine <sunshine@sunshineco.com>,
	Christian Couder <christian.couder@gmail.com>,
	Heba Waly <heba.waly@gmail.com>
Subject: Re: What's cooking in git.git (Aug 2020, #07; Thu, 27)
Date: Sat, 29 Aug 2020 11:28:09 -0700	[thread overview]
Message-ID: <xmqq1rjpjohy.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CA+CkUQ-SsxrJk+7e-ygm8FfCto6XZt2Ts9UcTMpgkmAQWZkLhA@mail.gmail.com> (Hariom verma's message of "Sat, 29 Aug 2020 15:43:13 +0530")

Hariom verma <hariom18599@gmail.com> writes:

> On Fri, Aug 28, 2020 at 3:14 AM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> [Cooking]
>>
>> * hv/ref-filter-trailers-atom-parsing-fix (2020-08-21) 2 commits
>>   (merged to 'next' on 2020-08-24 at 79b27f3263)
>>  + ref-filter: 'contents:trailers' show error if `:` is missing
>>  + t6300: unify %(trailers) and %(contents:trailers) tests
>> ...
>
> After a discussion, we agreed on keeping the helper function instead
> on duplicating code in "ref-filter: 'contents:trailers' show error if
> `:` is missing"
> There is a high possibility we might want to reuse helper in other places too.
> Especially in the case of newly added "%(subject:sanitize)", if we
> also want "%(contents:subject:sanitize)" to work.
>
> Full discussion:
> https://public-inbox.org/git/CA+CkUQ8Gst2RTaXY6t+ytWu_9Pu7eqnRYRrnawRwYd_NN=u0Lg@mail.gmail.com/
>
> I'm about to send the updated patch series soon.

Days after the topic got merged to 'next' is not a time to send any
updated patch series.  It should come in the form of incremental
update on top of what is already there.

IIRC, the code in question is good for the purpose of what already
exists and is easier to follow without helper.  When we need to make
the code more elaborabed and/or when we actually have the second
callsite would be the ideal time to introduce such a helper as a
preliminay clean-up patch early in such a follow-on series that
would happen after the "fix" in question graduates, I would think.

To be honest, I am not sure if we even need an incremental on top
right now, unless we want to delay the two patches to fix real
breakage above and make them wait for patches that adds features
that require to call the same helper from elsewhere.

Thanks.

  reply	other threads:[~2020-08-29 18:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27 21:43 What's cooking in git.git (Aug 2020, #07; Thu, 27) Junio C Hamano
2020-08-27 23:34 ` Jeff King
2020-08-27 23:36   ` Junio C Hamano
2020-08-28  0:39     ` Taylor Blau
2020-08-28  6:26       ` Jeff King
2020-08-28  8:31         ` Jeff King
2020-08-28 18:09           ` Taylor Blau
2020-08-28  2:16 ` Elijah Newren
2020-08-29  4:28   ` Matheus Tavares Bernardino
2020-08-28 15:48 ` ds/maintenance-part-[1-2] (was: What's cooking in git.git (Aug 2020, #07; Thu, 27)) Derrick Stolee
2020-08-28 20:09 ` What's cooking in git.git (Aug 2020, #07; Thu, 27) Hariom verma
2020-08-28 20:51   ` Junio C Hamano
2020-08-29 13:26     ` Hariom verma
2020-08-29 10:13 ` Hariom verma
2020-08-29 18:28   ` Junio C Hamano [this message]
2020-08-29 13:20     ` Hariom verma
2020-08-29 18:59       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq1rjpjohy.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=hariom18599@gmail.com \
    --cc=heba.waly@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).