From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 9A8CE1F4B4 for ; Mon, 28 Sep 2020 23:43:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726867AbgI1XnO (ORCPT ); Mon, 28 Sep 2020 19:43:14 -0400 Received: from pb-smtp20.pobox.com ([173.228.157.52]:51065 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726379AbgI1XnO (ORCPT ); Mon, 28 Sep 2020 19:43:14 -0400 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 19BECF1638; Mon, 28 Sep 2020 19:43:14 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=sasl; bh=Km+A55F/6h3LVsLzo/on2gh0RXM=; b=rcVd9A70CgNGp640lTIX 5gVNoOCimxvVxceOGeBrch0XUkpDcZiPCzer9qQIowsre1u7Fk3bsdDqMd6jZKaz 7AuBzo3SP3TPKPRklOEOwkHwOc1zm1CPOkiqtIWRL6vpItAX3IdI5a9HXX9z8hr6 YYcWLai5B0syzRRz3kX7jD0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; q=dns; s=sasl; b=ulaDbAjGic3CoOMTgiIFaxEqz37+PnWGZZmCqI/FQFbu5U Lk2dDWAcpGSzMejUjmtosrmp0S57axGEmSQ5z4enGajNMtHC+ZhY6dhvPIzBNPls UBDMRwJFinob6yx7nJmAwlH5y3RPtavlHKDSQj8rh1iYmyTfAQrtu2ZpSouuU= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 12481F1637; Mon, 28 Sep 2020 19:43:14 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 4C125F1636; Mon, 28 Sep 2020 19:43:11 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jonathan Tan Cc: git@vger.kernel.org, stolee@gmail.com Subject: Re: [PATCH v2 2/2] fetch: do not override partial clone filter References: Date: Mon, 28 Sep 2020 16:43:09 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 5E6C7DF8-01E4-11EB-A777-F0EA2EB3C613-77302942!pb-smtp20.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jonathan Tan writes: > test_expect_success 'partial clone with -o' ' > partial_clone_server server && > - git clone -o blah --filter=blob:limit=0 "file://$(pwd)/server" client > + git clone -o blah --filter=blob:limit=0 "file://$(pwd)/server" client && > + test_cmp_config -C client "blob:limit=0" --get-all remote.blah.partialclonefilter > ' Makes sense to piggyback on this existing test. It also makes sense to ensure that the original one is all and the only filter that is being configured. Will queue. Let's merge them to 'next'.