From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 943CA1F86C for ; Tue, 1 Dec 2020 20:22:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392407AbgLAUVo (ORCPT ); Tue, 1 Dec 2020 15:21:44 -0500 Received: from pb-smtp2.pobox.com ([64.147.108.71]:60641 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390839AbgLAUVo (ORCPT ); Tue, 1 Dec 2020 15:21:44 -0500 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id C4D428EC2E; Tue, 1 Dec 2020 15:21:01 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=4KJqjuC4RgtI kB+5wWvi/Yyen8M=; b=d44AiAF5lK4Qn4xeXC/9cQO71K349qzUV5O4wtfYZhUH gkApMos0Qi7yy6T0yy58MyQoQqWji8cE0Kru5vvK4suXikYMTyRlc9MBa+RFYn5o w/klxBJ2RXozYtelJ3ULaysApK/qqKdVB2afUJ9WAcG6nbq/YOx0vjnnVkzyYHA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=oL1sK+ 55v/XNTKZeC0kGDXZfXVkZJES2xI758Gwzwaj5NSoIJzbkV5cPxHC8PAFFyc3Fl6 +r9Q9BKC/XUaJiXKTeTbnk72Gl+SfC3X7TNnEivja9rlVKDIkNB80a9kqIU4UURW 6dRffk8rtNpUedBhl/YH4Ne8BPVd9KLvccViE= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 9B69F8EC2D; Tue, 1 Dec 2020 15:21:01 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id B2C5A8EC2B; Tue, 1 Dec 2020 15:21:00 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Jeff King , "brian m . carlson" , Eric Sunshine , Johannes Schindelin Subject: Re: [PATCH v2 03/10] mktag: reword write_object_file() error References: <20201126012854.399-1-avarab@gmail.com> <20201126222257.5629-4-avarab@gmail.com> Date: Tue, 01 Dec 2020 12:20:59 -0800 In-Reply-To: <20201126222257.5629-4-avarab@gmail.com> (=?utf-8?B?IsOGdmFy?= =?utf-8?B?IEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Thu, 26 Nov 2020 23:22:50 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: BA79FD54-3412-11EB-9BD1-74DE23BA3BAF-77302942!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > Change the error message emitted when write_object_file() fails to > make more sense. At this point we're not writing a "tag file" (which > as an aside we never do, we just write to stdout). We are writing an > annotated tag object, let's say that instead. > > Signed-off-by: =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason > --- > builtin/mktag.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/builtin/mktag.c b/builtin/mktag.c > index ff7ac8e0e5..603b55aca0 100644 > --- a/builtin/mktag.c > +++ b/builtin/mktag.c > @@ -171,7 +171,7 @@ int cmd_mktag(int argc, const char **argv, const ch= ar *prefix) > die("invalid tag signature file"); > =20 > if (write_object_file(buf.buf, buf.len, tag_type, &result) < 0) > - die("unable to write tag file"); > + die("unable to write annotated tag object"); "write an annotated tag object"? It is not just this call to die(), but we'd eventually want to _(l10n/i18= n) these messages. Perhaps in a separate step but on all messages fed to die/error/warn in this file. > =20 > strbuf_release(&buf); > printf("%s\n", oid_to_hex(&result));