From: Junio C Hamano <gitster@pobox.com>
To: Johannes Altmanninger <aclopte@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Re* [PATCH] diff: suppress --name-only paths where all hunks are ignored
Date: Mon, 21 Dec 2020 11:29:38 -0800 [thread overview]
Message-ID: <xmqq1rfjlzz1.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201220223435.tmo5ty5tzwu7et4d@gmail.com> (Johannes Altmanninger's message of "Sun, 20 Dec 2020 23:34:35 +0100")
Johannes Altmanninger <aclopte@gmail.com> writes:
>> +test_expect_success '-w and --exit-code interact sensibly' '
>
> Maybe 'exit with 0 when all changes are ignored by -w' though either version
> is fine because I think the intention of the test is already obvious.
Yeah, 'sensibly' is a zero-bit phrase and the letters are better
spent on describing what we deem sensible more clearly. Thanks.
prev parent reply other threads:[~2020-12-21 19:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 19:00 Unexpected behavior on diff -I<regex> --name-only Johannes Altmanninger
2020-12-14 19:49 ` Junio C Hamano
2020-12-16 23:18 ` Johannes Altmanninger
2020-12-16 23:18 ` [PATCH] diff: suppress --name-only paths where all hunks are ignored Johannes Altmanninger
2020-12-17 1:27 ` Re* " Junio C Hamano
2020-12-20 22:34 ` Johannes Altmanninger
2020-12-21 19:29 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1rfjlzz1.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=aclopte@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).