From: Junio C Hamano <gitster@pobox.com>
To: ZheNing Hu <adlternative@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: What's cooking in git.git (Apr 2021, #06; Thu, 29)
Date: Mon, 03 May 2021 10:46:44 +0900 [thread overview]
Message-ID: <xmqq1raobncr.fsf@gitster.g> (raw)
In-Reply-To: <CAOLTT8TWLUCOnL=s-SgCaJYbOw7YCyX5WNssZw5HCspaSAoxmw@mail.gmail.com> (ZheNing Hu's message of "Sun, 2 May 2021 20:00:02 +0800")
ZheNing Hu <adlternative@gmail.com> writes:
>> * zh/pretty-date-human (2021-04-27) 1 commit
>> - pretty: provide human date format
>> (this branch uses ab/pretty-date-format-tests.)
>>
>> "git log --format=..." placeholders learned %ah/%ch placeholders to
>> request the --date=human output.
>>
>> Will merge to 'next'?
>>
>
> Here is a small typo error, I forget a small blank, which was pointed
> out by Josh
> Soref in https://github.com/gitgitgadget/git/pull/939
>
> - '%ch':: committer date, human style(like the `--date=human` option of
> + '%ch':: committer date, human style (like the `--date=human` option of
Please update it with an incremental patch as the topic has been
merged to 'next' a few days ago already.
Also plase trim your quotes to exclude description of topics that
you are not commenting on.
>> * zh/trailer-cmd (2021-04-17) 2 commits
>> - trailer: add new .cmd config option
>> - docs: correct description of .command
>>
>> The way the command line specified by the trailer.<token>.command
>> configuration variable receives the end-user supplied value was
>> both error prone and misleading. An alternative to achieve the
>> same goal in a safer and more intuitive way has been added, as
>> the trailer.<token>.cmd configuration variable, to replace it.
>>
>> Expecting a reroll, after waiting for "commit --trailer" to stabilize.
>>
>
> I have a little doubt here. Do I need to modify the "Commit-Count"
> example in the docs immediately? I thought this should be left to
> the next step?
>
> If necessary, I will make changes immediately.
We've done the "after waiting" part already, so I should have
updated the topic summary for this one.
I just re-read the second patch and the count example that leaves an
empty "commit-count:" does look strange. We probably want to update
it before the topic hits 'next'. While at it, you might want to add
the "Helped-by: " example we discussed.
The phrase "global script" looks strange---just call it "script"
would be much easier to understand, as things that are in ~/bin do
not sound "global" to everybody (it is effective across
repositories, so is a bit wider than per-repository, but it is of
course not visible to other users).
Thanks.
next prev parent reply other threads:[~2021-05-03 1:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 9:15 What's cooking in git.git (Apr 2021, #06; Thu, 29) Junio C Hamano
2021-04-30 9:34 ` Ævar Arnfjörð Bjarmason
2021-05-02 6:47 ` Junio C Hamano
2021-05-06 4:29 ` Junio C Hamano
2021-05-06 15:36 ` Ævar Arnfjörð Bjarmason
2021-05-03 2:38 ` Junio C Hamano
2021-05-02 12:00 ` ZheNing Hu
2021-05-03 1:46 ` Junio C Hamano [this message]
2021-05-03 13:35 ` ZheNing Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1raobncr.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=adlternative@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).