From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: "Jeff King" <peff@peff.net>,
git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Richard Hansen" <rhansen@rhansen.org>
Subject: Re: Re* [PATCH] doc: glossary: add entry for revision range
Date: Tue, 18 May 2021 09:51:10 +0900 [thread overview]
Message-ID: <xmqq1ra46f0h.fsf@gitster.g> (raw)
In-Reply-To: <60a2daa57d8a6_13c370208f3@natae.notmuch> (Felipe Contreras's message of "Mon, 17 May 2021 16:05:41 -0500")
Felipe Contreras <felipe.contreras@gmail.com> writes:
> Junio C Hamano wrote:
>> Jeff King <peff@peff.net> writes:
>>
>> > I agree that if the purpose is to be illustrative, using shortcuts like
>> > "an empty endpoint means HEAD" is not helpful. And likewise for "@"; if
>> > you need to have "revision range" defined, there is a good chance that
>> > you don't know about shortcuts like "@" either.
>> >
>> > So I would prefer something more explicit (whether it's "mybranch" or
>> > "end" or "HEAD" or whatever).
>>
>> Perhaps. Being illustrative for common use case is also important,
>> so I do not mind teaching "missing endpoint at either side defaults
>> to HEAD" early.
>
> A glossary is not a place to teach (anything other than the definition).
> It's supposed to contain glosses (brief explanations).
Fair enough. Then let's limit ourselves to the definition, but give
a correct one. It is not "syntax" that the phrase "revision range"
refers to; it is what is specified by that syntax.
[[def_revision_range]]revision range::
A set of connected commits to work on, usually specified by
giving two end points, like `origin..mytopic`. See the
'Specifying Ranges' and 'Revision Range Summary' sections of
linkgit:gitrevisions[7] for details.
next prev parent reply other threads:[~2021-05-18 0:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 20:37 [PATCH] doc: glossary: add entry for revision range Felipe Contreras
2021-05-17 7:46 ` Re* " Junio C Hamano
2021-05-17 10:30 ` Felipe Contreras
2021-05-17 11:55 ` Jeff King
2021-05-17 17:22 ` Felipe Contreras
2021-05-18 6:59 ` Jeff King
2021-05-18 12:28 ` Felipe Contreras
2021-05-17 19:26 ` Junio C Hamano
2021-05-17 21:05 ` Felipe Contreras
2021-05-18 0:51 ` Junio C Hamano [this message]
2021-05-18 1:26 ` Felipe Contreras
2021-05-18 2:08 ` Jeff King
2021-05-18 2:57 ` Junio C Hamano
2021-05-18 5:20 ` Felipe Contreras
2021-05-18 5:02 ` Felipe Contreras
2021-05-18 6:55 ` Jeff King
2021-05-18 11:42 ` Felipe Contreras
2021-05-18 12:47 ` Jeff King
2021-05-18 21:09 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1ra46f0h.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=rhansen@rhansen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).