From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: "Taylor Blau" <me@ttaylorr.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jonathan Nieder" <jrnieder@gmail.com>,
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Derrick Stolee" <derrickstolee@github.com>,
"Derrick Stolee" <dstolee@microsoft.com>
Subject: Re: [PATCH] t1092: use GIT_PROGRESS_DELAY for consistent results
Date: Wed, 26 May 2021 05:46:16 +0900 [thread overview]
Message-ID: <xmqq1r9uee3r.fsf@gitster.g> (raw)
In-Reply-To: <9d6568ee-c9bf-b349-d1a6-0bb2fcf06dab@gmail.com> (Derrick Stolee's message of "Tue, 25 May 2021 06:54:02 -0400")
Derrick Stolee <stolee@gmail.com> writes:
> On 5/25/2021 2:32 AM, Junio C Hamano wrote:
>> Derrick Stolee <stolee@gmail.com> writes:
>>
>>>> So we silently convert -1 to 2^64-1, and call it a day.
>>>
>>> That works for me. I'll send a v2 with that tomorrow unless someone
>>> presents a better option.
>>
>> I'll queue with this tweak for tonight's integration run.
>>
>> ...
> Thank you for proactively modifying the patch. This works
> for me. I didn't realize that this was affecting other
> contributors [1] until I woke up this morning.
>
> [1] https://lore.kernel.org/git/036b01d750ed$642b75c0$2c826140$@nexbridge.com/
Well, not so well X-<. It seems that some builds are not happy with
this change. See https://github.com/git/git/actions/runs/876229761
specifically these two:
https://github.com/git/git/runs/2669177395?check_suite_focus=true#step:7:3549
https://github.com/git/git/runs/2669080101?check_suite_focus=true#step:6:988
I suspect that it has something to do with 32-bit platforms?
Thanks.
next prev parent reply other threads:[~2021-05-25 20:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 19:55 [PATCH] t1092: use GIT_PROGRESS_DELAY for consistent results Derrick Stolee via GitGitGadget
2021-05-24 20:28 ` Jonathan Nieder
2021-05-24 20:38 ` Derrick Stolee
2021-05-24 21:42 ` Taylor Blau
2021-05-24 22:57 ` Ævar Arnfjörð Bjarmason
2021-05-25 0:13 ` Taylor Blau
2021-05-25 0:39 ` Derrick Stolee
2021-05-25 6:32 ` Junio C Hamano
2021-05-25 10:54 ` Derrick Stolee
2021-05-25 20:46 ` Junio C Hamano [this message]
2021-05-25 21:14 ` Junio C Hamano
2021-05-25 21:49 ` Taylor Blau
2021-05-25 2:54 ` Junio C Hamano
2021-05-25 15:10 ` Taylor Blau
2021-05-25 7:39 ` Ævar Arnfjörð Bjarmason
2021-05-25 8:06 ` Junio C Hamano
2021-05-25 2:49 ` Junio C Hamano
2021-05-25 2:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1r9uee3r.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jrnieder@gmail.com \
--cc=me@ttaylorr.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).