From: Junio C Hamano <gitster@pobox.com>
To: Alex Henrie <alexhenrie24@gmail.com>
Cc: git@vger.kernel.org, paulus@ozlabs.org
Subject: Re: [PATCH v3 4/4] gitk: pass --no-graph to `git log`
Date: Fri, 11 Feb 2022 10:12:06 -0800 [thread overview]
Message-ID: <xmqq1r09clxl.fsf@gitster.g> (raw)
In-Reply-To: <20220211163627.598166-4-alexhenrie24@gmail.com> (Alex Henrie's message of "Fri, 11 Feb 2022 09:36:27 -0700")
Alex Henrie <alexhenrie24@gmail.com> writes:
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
> v3: no changes
> ---
> gitk-git/gitk | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
Please base a patch on gitk part to base on Paul's tree, not mine,
meaning that the first few lines of diff should begin like so:
diff --git a/gitk b/gitk
index ...
--- a/gitk
+++ b/gitk
and not as part of the series.
What the first two patches want to do is a good thing regardless, so
I'll take a deeper look at them and queue them. I am very skeptical
to log.graph=yes/no configuration for obvious reasons that setting
such a variable *will* break existing tools and users. It is not
even "it might break but we don't know until we try", as this patch
loudly demonstrates.
Thanks.
> diff --git a/gitk-git/gitk b/gitk-git/gitk
> index 23d9dd1fe0..24099ce0b8 100755
> --- a/gitk-git/gitk
> +++ b/gitk-git/gitk
> @@ -411,8 +411,8 @@ proc start_rev_list {view} {
> }
>
> if {[catch {
> - set fd [open [concat | git log --no-color -z --pretty=raw $show_notes \
> - --parents --boundary $args "--" $files] r]
> + set fd [open [concat | git log --no-color --no-graph -z --pretty=raw \
> + $show_notes --parents --boundary $args "--" $files] r]
> } err]} {
> error_popup "[mc "Error executing git log:"] $err"
> return 0
> @@ -559,8 +559,9 @@ proc updatecommits {} {
> set args $vorigargs($view)
> }
> if {[catch {
> - set fd [open [concat | git log --no-color -z --pretty=raw $show_notes \
> - --parents --boundary $args "--" $vfilelimit($view)] r]
> + set fd [open [concat | git log --no-color --no-graph -z --pretty=raw
> + $show_notes --parents --boundary $args "--"
> + $vfilelimit($view)] r]
> } err]} {
> error_popup "[mc "Error executing git log:"] $err"
> return
next prev parent reply other threads:[~2022-02-11 18:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 16:36 [PATCH v3 1/4] log: fix memory leak if --graph is passed multiple times Alex Henrie
2022-02-11 16:36 ` [PATCH v3 2/4] log: add a --no-graph option Alex Henrie
2022-02-11 19:02 ` Junio C Hamano
2022-02-11 19:20 ` Alex Henrie
2022-02-11 16:36 ` [PATCH v3 3/4] log: add a log.graph config option Alex Henrie
2022-02-11 16:36 ` [PATCH v3 4/4] gitk: pass --no-graph to `git log` Alex Henrie
2022-02-11 18:12 ` Junio C Hamano [this message]
2022-02-11 19:05 ` Alex Henrie
2022-02-11 19:20 ` Junio C Hamano
2022-02-11 20:00 ` Junio C Hamano
2022-02-11 20:11 ` Alex Henrie
2022-02-11 20:08 ` Alex Henrie
2022-02-11 18:51 ` [PATCH v3 1/4] log: fix memory leak if --graph is passed multiple times Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1r09clxl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=alexhenrie24@gmail.com \
--cc=git@vger.kernel.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).