From: Junio C Hamano <gitster@pobox.com>
To: "Yuyi Wang via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Yuyi Wang <Strawberry_Str@hotmail.com>
Subject: Re: [PATCH] Add pcre2 support for cmake build system.
Date: Wed, 18 May 2022 15:02:47 -0700 [thread overview]
Message-ID: <xmqq1qwqts6w.fsf@gitster.g> (raw)
In-Reply-To: <pull.1267.git.git.1652846305514.gitgitgadget@gmail.com> (Yuyi Wang via GitGitGadget's message of "Wed, 18 May 2022 03:58:25 +0000")
"Yuyi Wang via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Yuyi Wang <Strawberry_Str@hotmail.com>
>
> This commit fixes one of the TODOs listed in the CMakeLists.txt.
>
> There's also some small fix to ensure it builds successfully.
>
> Signed-off-by: Yuyi Wang <Strawberry_Str@hotmail.com>
> ---
I haven't worked on the CMakeLists but is the above description
sufficient to tell what is going on if given to those who are
familiar with it (I ask because it is not clear at all to me).
> diff --git a/contrib/buildsystems/CMakeLists.txt b/contrib/buildsystems/CMakeLists.txt
> index 185f56f414f..99d6cb963c4 100644
> --- a/contrib/buildsystems/CMakeLists.txt
> +++ b/contrib/buildsystems/CMakeLists.txt
> @@ -54,7 +54,7 @@ set(CMAKE_SOURCE_DIR ${CMAKE_CURRENT_LIST_DIR}/../..)
>
> option(USE_VCPKG "Whether or not to use vcpkg for obtaining dependencies. Only applicable to Windows platforms" ON)
> if(NOT WIN32)
> - set(USE_VCPKG OFF CACHE BOOL FORCE)
> + set(USE_VCPKG OFF CACHE BOOL "" FORCE)
> endif()
Is this "small fix to ensure it builds successfully"? To those who
do not need/want to use pcre2, is this hunk still needed to "build
successfully", or is this something that becomes necessary only
because we have other hunks in this patch to add support to pcre2?
If the former, then perhaps the change deserves to be its own patch
with own explanation why it is necessary, what breaks without it,
etc.
Thanks.
next prev parent reply other threads:[~2022-05-18 22:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 3:58 [PATCH] Add pcre2 support for cmake build system Yuyi Wang via GitGitGadget
2022-05-18 22:02 ` Junio C Hamano [this message]
2022-05-19 16:18 ` Yuyi Wang
2022-05-23 18:35 ` Derrick Stolee
2022-05-23 18:36 ` Derrick Stolee
2022-05-24 6:38 ` [PATCH v2 0/2] " Yuyi Wang via GitGitGadget
2022-05-24 6:38 ` [PATCH v2 1/2] Fix CMakeLists.txt on Linux Yuyi Wang via GitGitGadget
2022-05-24 23:04 ` Junio C Hamano
2022-05-24 6:38 ` [PATCH v2 2/2] Add pcre2 support for cmake build system Yuyi Wang via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1qwqts6w.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Strawberry_Str@hotmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).