From: Junio C Hamano <gitster@pobox.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: Jeff Hostetler <jeffhost@microsoft.com>, git@vger.kernel.org
Subject: Re: t7527 intermittent failure on macOS APFS and possible fix
Date: Fri, 12 Aug 2022 17:45:51 -0700 [thread overview]
Message-ID: <xmqq1qtlas3k.fsf@gitster.g> (raw)
In-Reply-To: <YvbtVoP01fHF2ka3@danh.dev> ("Đoàn Trần Công Danh"'s message of "Sat, 13 Aug 2022 07:16:22 +0700")
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
>> Aren't these protocol drivers?
>
> The "answer" strbuf is the response from fsmonitor daemon, I think.
> The write_in_full to fd 1 is test-tool writes down the answer to
> stdout.
Ahh, then please scratch everything I said about this part. Your
original implementation makes it more clear that we are "dumping"
what we got from the daemon, and then adding LF for our own
readability. I somehow mistook the code to be preparing and sending
protocol message to the other end (iow, fd #1 was connected to
"them").
Sorry about the gotcha, and thanks for straightening me out.
next prev parent reply other threads:[~2022-08-13 0:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 13:52 t7527 intermittent failure on macOS APFS and possible fix Đoàn Trần Công Danh
2022-08-12 18:08 ` Junio C Hamano
2022-08-13 0:16 ` Đoàn Trần Công Danh
2022-08-13 0:45 ` Junio C Hamano [this message]
2022-08-14 6:52 ` Jeff King
2022-08-17 20:23 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1qtlas3k.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).