From: Junio C Hamano <gitster@pobox.com>
To: Maxim Cournoyer <maxim@guixotic.coop>
Cc: git@vger.kernel.org, Andreas Schwab <schwab@linux-m68k.org>,
"brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH v4 0/3] git-credential-netrc: better symbolic port names support
Date: Wed, 25 Jun 2025 09:49:28 -0700 [thread overview]
Message-ID: <xmqq1pr7wyuf.fsf@gitster.g> (raw)
In-Reply-To: <20250625142511.28857-1-maxim@guixotic.coop> (Maxim Cournoyer's message of "Wed, 25 Jun 2025 23:25:08 +0900")
Maxim Cournoyer <maxim@guixotic.coop> writes:
> This revision fixes a single white space in a new test added in 3/3.
The contents exactly match what I locally have (as I fixed up the
previous round locally before you sent in this iteration).
[v4 0/3] does not look like a reply to [v3 0/3], though. It has
these header lines
Message-ID: <20250625142511.28857-1-maxim@guixotic.coop>
In-Reply-To: <87ecv8k4y9.fsf@terra.mail-host-address-is-not-set>
References: <87ecv8k4y9.fsf@terra.mail-host-address-is-not-set>
and refers to the message in the discussion thread of [v3 0/3] in
which you said "I'll now send a v4 fixing the white space issue,
making sure to --in-reply-to=$message-id-of-v3-cover-letter."
No need to resend this round just to fix the threading, of course.
Thanks.
> Maxim Cournoyer (3):
> contrib: use a more portable shebang for git-credential-netrc
> contrib: warn for invalid netrc file ports in git-credential-netrc
> contrib: better support symbolic port names in git-credential-netrc
>
> contrib/credential/netrc/git-credential-netrc.perl | 14 +++++++++++---
> contrib/credential/netrc/test.pl | 8 ++++----
> git-send-email.perl | 11 +++++++++++
> perl/Git.pm | 13 +++++++++++++
> t/t9001-send-email.sh | 7 +++++++
> 5 files changed, 46 insertions(+), 7 deletions(-)
next prev parent reply other threads:[~2025-06-25 17:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 4:12 [PATCH] contrib: Honor symbolic port in git-credential-netrc Maxim Cournoyer
2025-06-20 13:48 ` Junio C Hamano
2025-06-20 14:22 ` Andreas Schwab
2025-06-20 16:39 ` Junio C Hamano
2025-06-21 13:57 ` Maxim Cournoyer
2025-06-23 3:28 ` Maxim Cournoyer
2025-06-23 3:34 ` Maxim Cournoyer
2025-06-20 19:03 ` brian m. carlson
2025-06-21 13:29 ` Maxim Cournoyer
2025-06-21 15:52 ` brian m. carlson
2025-06-22 15:25 ` [PATCH v2 0/3] git-credential-netrc: better symbolic port names support Maxim Cournoyer
2025-06-22 15:25 ` [PATCH v2 1/3] contrib: use a more portable shebang for git-credential-netrc Maxim Cournoyer
2025-06-22 15:25 ` [PATCH v2 2/3] contrib: warn for invalid netrc file ports in git-credential-netrc Maxim Cournoyer
2025-06-22 15:25 ` [PATCH v2 3/3] contrib: better support symbolic port names " Maxim Cournoyer
2025-06-23 18:03 ` Junio C Hamano
2025-06-24 1:51 ` Maxim Cournoyer
2025-06-24 1:48 ` [PATCH v3 0/3] git-credential-netrc: better symbolic port names support Maxim Cournoyer
2025-06-24 16:04 ` Junio C Hamano
2025-06-24 23:55 ` Maxim Cournoyer
2025-06-25 0:24 ` Junio C Hamano
2025-06-25 1:03 ` Maxim Cournoyer
2025-06-25 14:25 ` [PATCH v4 " Maxim Cournoyer
2025-06-25 14:25 ` [PATCH v4 1/3] contrib: use a more portable shebang for git-credential-netrc Maxim Cournoyer
2025-06-25 14:25 ` [PATCH v4 2/3] contrib: warn for invalid netrc file ports in git-credential-netrc Maxim Cournoyer
2025-06-25 14:25 ` [PATCH v4 3/3] contrib: better support symbolic port names " Maxim Cournoyer
2025-06-25 16:49 ` Junio C Hamano [this message]
2025-06-26 1:15 ` [PATCH v4 0/3] git-credential-netrc: better symbolic port names support Maxim Cournoyer
2025-06-24 1:48 ` [PATCH v3 1/3] contrib: use a more portable shebang for git-credential-netrc Maxim Cournoyer
2025-06-24 1:48 ` [PATCH v3 2/3] contrib: warn for invalid netrc file ports in git-credential-netrc Maxim Cournoyer
2025-06-24 1:48 ` [PATCH v3 3/3] contrib: better support symbolic port names " Maxim Cournoyer
2025-06-24 16:06 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq1pr7wyuf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=maxim@guixotic.coop \
--cc=sandals@crustytoothpaste.net \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).