git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Paolo Giarrusso <p.giarrusso@gmail.com>
Cc: Tay Ray Chuan <rctay89@gmail.com>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: Fwd: [PATCH] git-subtree: Avoid using echo -n even indirectly
Date: Wed, 09 Oct 2013 13:26:19 +0200	[thread overview]
Message-ID: <vpqy562y9b8.fsf@anie.imag.fr> (raw)
In-Reply-To: <CAAcnjCQ+c=8wYZkqS7VzZ_bDDDkSwdQ3qdz77osrSpKDS9ON7Q@mail.gmail.com> (Paolo Giarrusso's message of "Wed, 9 Oct 2013 12:32:31 +0200")

Paolo Giarrusso <p.giarrusso@gmail.com> writes:

> Otherwise, one could
> change say to use printf, but that's more invasive.

"invasive" in the sense that it impacts indirectly more callers, but are
there really cases where "echo" is needed when calling "say"? Aren't
there other potential bugs when arbitrary strings are passed to "say",
that would be fixed by using printf once and for all?

The patch would look like the one I did in 89b0230a20 (Wed Aug 7 2013,
die_with_status: use "printf '%s\n'", not "echo").

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  parent reply	other threads:[~2013-10-09 11:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-09  3:57 [PATCH] git-subtree: Avoid using echo -n even indirectly Paolo G. Giarrusso
2013-10-09 10:20 ` Tay Ray Chuan
     [not found]   ` <CAAcnjCT1bdR+9kDW=q_326OhiSMm3_j-yOh0-ayTkObK3bZ3bQ@mail.gmail.com>
2013-10-09 10:32     ` Fwd: " Paolo Giarrusso
2013-10-09 10:46       ` Johannes Sixt
2013-10-09 11:26       ` Matthieu Moy [this message]
2013-10-09 12:03         ` Paolo Giarrusso
2013-10-09 19:48           ` Jeff King
2013-10-09 21:11       ` Jonathan Nieder
2013-10-11  9:32         ` Paolo Giarrusso
  -- strict thread matches above, loose matches on Subject: below --
2013-10-28 14:04 Paolo Giarrusso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpqy562y9b8.fsf@anie.imag.fr \
    --to=matthieu.moy@grenoble-inp.fr \
    --cc=git@vger.kernel.org \
    --cc=p.giarrusso@gmail.com \
    --cc=rctay89@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).