From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Jorge-Juan.Garcia-Garcia@ensimag.imag.fr
Cc: git@vger.kernel.org, gitster@pobox.com,
Mathieu Lienard--Mayor <Mathieu.Lienard--Mayor@ensimag.imag.fr>
Subject: Re: [PATCH v4 2/2] status:introduce status.branch to enable --branch by default
Date: Tue, 11 Jun 2013 15:43:15 +0200 [thread overview]
Message-ID: <vpqwqq03gr0.fsf@anie.imag.fr> (raw)
In-Reply-To: <1370957645-17905-2-git-send-email-Jorge-Juan.Garcia-Garcia@ensimag.imag.fr> (Jorge-Juan Garcia-Garcia's message of "Tue, 11 Jun 2013 15:34:05 +0200")
Jorge-Juan.Garcia-Garcia@ensimag.imag.fr writes:
> +test_expect_success '"status.branch=true" different from "--no-branch"' '
> + git -c status.branch=true status -s >actual &&
> + git status -s --no-branch >expected_nobranch &&
Two nitpicks:
There are two spaces before >, there should be one.
If the first "git" command fails, then you fail to create
expected_nobranch and the other tests fail too. Creating
expected_nobranch before actual would solve this. You have the same
issue in PATCH 1/2.
With or without these fixed,
Reviewed-by: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
(both patches)
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-06-11 13:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-11 13:34 [PATCH v4 1/2] status: introduce status.short to enable --short by default Jorge-Juan.Garcia-Garcia
2013-06-11 13:34 ` [PATCH v4 2/2] status:introduce status.branch to enable --branch " Jorge-Juan.Garcia-Garcia
2013-06-11 13:43 ` Matthieu Moy [this message]
2013-06-11 21:38 ` [PATCH v4 1/2] status: introduce status.short to enable --short " Junio C Hamano
2013-06-12 6:57 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqwqq03gr0.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=Jorge-Juan.Garcia-Garcia@ensimag.imag.fr \
--cc=Mathieu.Lienard--Mayor@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).