From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Javier.Roucher-Iglesias@ensimag.imag.fr
Cc: git@vger.kernel.org, Javier Roucher <jroucher@gmail.com>,
Pavel Volek <Pavel.Volek@ensimag.imag.fr>,
NGUYEN Kim Thuat <Kim-Thuat.Nguyen@ensimag.imag.fr>,
ROUCHER IGLESIAS Javier <roucherj@ensimag.imag.fr>
Subject: Re: [PATCH/RFC] credentials helpers+remote helpers
Date: Thu, 07 Jun 2012 19:13:06 +0200 [thread overview]
Message-ID: <vpqvcj32ggt.fsf@bauges.imag.fr> (raw)
In-Reply-To: <1339079743-31068-1-git-send-email-Javier.Roucher-Iglesias@ensimag.imag.fr> (Javier Roucher-Iglesias's message of "Thu, 7 Jun 2012 16:35:43 +0200")
> Subject: Re: [PATCH/RFC] credentials helpers+remote helpers
This is not a good title. The one you have below (which I suggested
off-list) should be the first line of the patch.
Javier.Roucher-Iglesias@ensimag.imag.fr writes:
> Add "git credential" plumbing command
(I mean this one)
> .gitignore | 1 +
> Documentation/git-credential.txt | 70 ++++++++++++++++++++++++++++++++++++++++
> Makefile | 1 +
> builtin.h | 1 +
> builtin/credential.c | 40 +++++++++++++++++++++++
> git.c | 1 +
No tests?
Since this new command is essentially a copy-paste of test-credential.c,
it would indeed make sense to replace test-credential calls in the
scripts by calls to this "git credential" command.
> index 0000000..a6e1d0a
> --- /dev/null
> +++ b/Documentation/git-credential.txt
This file is not valid asciidoc. Please, run "make doc" and see if the
generated HTML is right. Currently, it says
SUBDIR ../
make[1]: `GIT-VERSION-FILE' is up to date.
ASCIIDOC git-credential.html
asciidoc: ERROR: git-credential.txt: line 69: [blockdef-listing] missing closing delimiter
make: *** [git-credential.html] Error 1
(didn't I already mention it off-list?)
> +------------------
> +git credential [fill|approve|reject]
> +
> +------------------
[...]
> +static const char usage_msg[] =
> +"credential <fill|approve|reject> [helper...]";
Which one is right?
I already suggested several times that you get rid of this "helper"
argument (inherited from test-credential), or that you give it a better
API (e.g. --helper HELPER, but not positional argument). If this
argument is usefull, then keep it but it should be documented properly.
> +Git-credential permits to save username, password, host, path and protocol.
> +When you invoke git-credential, you can ask for a password, using the command
> +'git credential fill'.
Who is "you" here? This "you" is the developer writing a script using
"git credential", while this one :
> +-If it is not stored, git-credential will ask you to enter
> +the password:
> +
> + > Password for '[http|https]admin@localhost':
... is the user of the script. Please be more precise, e.g. "a script
can ask ...", "the user will be prompted for a password".
> +Then if password is correct, you can store using command
if _the_ password ... you can store _it_ using ...
> +If the password is refused, you can delete using command
delete _it_
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2012-06-07 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 14:35 [PATCH/RFC] credentials helpers+remote helpers Javier.Roucher-Iglesias
2012-06-07 17:13 ` Matthieu Moy [this message]
2012-06-07 19:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqvcj32ggt.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=Javier.Roucher-Iglesias@ensimag.imag.fr \
--cc=Kim-Thuat.Nguyen@ensimag.imag.fr \
--cc=Pavel.Volek@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=jroucher@gmail.com \
--cc=roucherj@ensimag.imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).