From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Jeff King <peff@peff.net>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"SZEDER Gábor" <szeder@ira.uka.de>,
"Sebastian Pipping" <webmaster@hartwork.org>,
"Git ML" <git@vger.kernel.org>
Subject: Re: "git add -u" broken in git 1.7.4?
Date: Thu, 10 Feb 2011 19:00:48 +0100 [thread overview]
Message-ID: <vpqpqqzahwv.fsf@bauges.imag.fr> (raw)
In-Reply-To: <20110209234621.GA12575@sigill.intra.peff.net> (Jeff King's message of "Wed\, 9 Feb 2011 18\:46\:21 -0500")
Jeff King <peff@peff.net> writes:
> I don't think it's worth moving ls-files/ls-tree. They're plumbing that
> people don't use frequently. So the cost of moving them is high (because
> we are breaking something meant to be scriptable) and the benefit is low
> (because users don't type them a lot).
Right. At some point, we may want to introduce a porcelain version of
"git ls-files", but we shouldn't change its default behavior.
> The archive behavior surprised me, and I would think it should be full-tree
> by default. But it is sort of plumbing-ish, in that people have probably
> scripted around and people _don't_ tend to create archives a lot.
Right. There are probably more calls to "git archive" in cron jobs and
web interface than directly from the command-line.
> That leaves clean. I would say from a consistency standpoint that it
> should go full-tree to match the other commands. But it is one of the
> most destructive commands, and making it full-tree makes it easier to
> accidentally delete, instead of accidentally fail to delete.
Agreed. That would be really bad surprise for an experience user to
upgrade Git, type "git clean -fdx" from a subdirectory, and to notice
the new behavior afterwards ;-).
> So depending on your view of the above, it may just be "add -u/-A" and
> "grep" that are worth switching.
Agreed.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2011-02-10 18:03 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 0:39 "git add -u" broken in git 1.7.4? Sebastian Pipping
2011-02-06 5:13 ` Jeff King
2011-02-06 19:35 ` Sebastian Pipping
2011-02-06 20:48 ` Matthieu Moy
2011-02-06 23:19 ` SZEDER Gábor
2011-02-06 23:49 ` Sebastian Pipping
2011-02-07 5:50 ` Junio C Hamano
2011-02-07 5:53 ` Jeff King
2011-02-07 6:46 ` Junio C Hamano
2011-02-07 7:29 ` Nguyen Thai Ngoc Duy
2011-02-07 18:34 ` SZEDER Gábor
2011-02-07 19:31 ` Junio C Hamano
2011-02-07 19:50 ` Jeff King
2011-02-08 10:05 ` SZEDER Gábor
2011-02-09 21:03 ` Jeff King
2011-02-09 22:40 ` Junio C Hamano
2011-02-09 23:46 ` Jeff King
2011-02-10 2:24 ` Nguyen Thai Ngoc Duy
2011-02-10 2:31 ` Jeff King
2011-02-10 2:46 ` Junio C Hamano
2011-02-10 7:46 ` Johannes Sixt
2011-02-10 8:13 ` Joshua Juran
2011-02-10 18:00 ` Matthieu Moy [this message]
2011-02-15 7:04 ` [PATCH] command-list.txt: mark git-archive plumbing Nguyen Thai Ngoc Duy
2011-02-15 19:11 ` Junio C Hamano
2011-02-16 9:32 ` Nguyen Thai Ngoc Duy
2011-02-07 20:57 ` "git add -u" broken in git 1.7.4? Matthieu Moy
2011-02-07 21:02 ` Jeff King
2011-02-07 21:49 ` Junio C Hamano
2011-02-08 1:25 ` Eric Raible
2011-02-08 2:16 ` Junio C Hamano
2011-02-07 6:48 ` Matthieu Moy
2011-02-07 8:27 ` Michael J Gruber
2011-02-07 11:15 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqpqqzahwv.fsf@bauges.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=szeder@ira.uka.de \
--cc=webmaster@hartwork.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).