From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCHv5 2/4] Let core.excludesfile default to $XDG_CONFIG_HOME/git/ignore Date: Mon, 04 Jun 2012 13:43:25 +0200 Message-ID: References: <1338585788-9764-1-git-send-email-Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr> <1338754481-27012-1-git-send-email-Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr> <1338754481-27012-2-git-send-email-Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr> Mime-Version: 1.0 Content-Type: text/plain Cc: git@vger.kernel.org, NGUYEN Huynh Khoi Nguyen , Valentin DUPERRAY , Franck JONAS , Thomas NGUY , Lucien KONG To: Huynh Khoi Nguyen NGUYEN X-From: git-owner@vger.kernel.org Mon Jun 04 13:48:14 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SbVlc-0004Fp-Vy for gcvg-git-2@plane.gmane.org; Mon, 04 Jun 2012 13:48:13 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759414Ab2FDLnj (ORCPT ); Mon, 4 Jun 2012 07:43:39 -0400 Received: from mx2.imag.fr ([129.88.30.17]:43741 "EHLO rominette.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754168Ab2FDLni (ORCPT ); Mon, 4 Jun 2012 07:43:38 -0400 Received: from mail-veri.imag.fr (mail-veri.imag.fr [129.88.43.52]) by rominette.imag.fr (8.13.8/8.13.8) with ESMTP id q54BYjUH024869 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Mon, 4 Jun 2012 13:34:46 +0200 Received: from bauges.imag.fr ([129.88.7.32]) by mail-veri.imag.fr with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1SbVh0-0006Ju-6a; Mon, 04 Jun 2012 13:43:26 +0200 In-Reply-To: <1338754481-27012-2-git-send-email-Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr> (Huynh Khoi Nguyen NGUYEN's message of "Sun, 3 Jun 2012 22:14:39 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (rominette.imag.fr [129.88.30.17]); Mon, 04 Jun 2012 13:34:46 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: q54BYjUH024869 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1339414490.03304@6MbRoWn2H1rqSo1kI7Fw3Q Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Huynh Khoi Nguyen NGUYEN writes: > If core.excludesfile is not defined, its default value will be > $XDG_CONFIG_HOME/git/ignore in order to follow XDG specification. If > $XDG_CONFIG_HOME is either not set or emty, $HOME/.config will be > used. It's not clear whether $HOME/.config will be used to replace $XDG_CONFIG_HOME or $XDG_CONFIG_HOME/git/ignore. I'd say explicitely $HOME/.config/git/ignore to avoid this. > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -483,7 +483,9 @@ core.excludesfile:: > '.git/info/exclude', git looks into this file for patterns > of files which are not meant to be tracked. "`~/`" is expanded > to the value of `$HOME` and "`~user/`" to the specified user's > - home directory. See linkgit:gitignore[5]. > + home directory. Its default value is $XDG_CONFIG_HOME/git/ignore. > + If $XDG_CONFIG_HOME is either not set or empty, $HOME/.config will > + be used. See linkgit:gitignore[5]. Likewise. > --- a/Documentation/gitignore.txt > +++ b/Documentation/gitignore.txt > @@ -50,7 +50,9 @@ the repository but are specific to one user's workflow) should go into > the `$GIT_DIR/info/exclude` file. Patterns which a user wants git to > ignore in all situations (e.g., backup or temporary files generated by > the user's editor of choice) generally go into a file specified by > -`core.excludesfile` in the user's `~/.gitconfig`. > +`core.excludesfile` in the user's `~/.gitconfig`. Its default value is > +$XDG_CONFIG_HOME/git/ignore. If $XDG_CONFIG_HOME is either not set or empty, > +$HOME/.config will be used. Likewise. Otherwise, sounds good. -- Matthieu Moy http://www-verimag.imag.fr/~moy/