From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: benoit.person@ensimag.fr
Cc: git@vger.kernel.org, Celestin Matte <celestin.matte@ensimag.fr>
Subject: Re: [PATCH V3 1/4] git-mw: Introduction of GitMediawiki.pm
Date: Sun, 16 Jun 2013 22:18:34 +0200 [thread overview]
Message-ID: <vpqobb5g679.fsf@anie.imag.fr> (raw)
In-Reply-To: <1371349893-7789-2-git-send-email-benoit.person@ensimag.fr> (benoit person's message of "Sun, 16 Jun 2013 04:31:30 +0200")
benoit.person@ensimag.fr writes:
> changes from the V2:
> - Add a way to test, without installation, code that uses GitMediawiki.pm.
This still needs to be documented, even very quickly, somewhere in the
code (e.g a comment in the Makefile).
> -build install clean:
> +copy_pm:
> + cp $(GIT_MEDIAWIKI_PM) $(GIT_ROOT_DIR)/perl/blib/lib/
I already commented on this:
http://thread.gmane.org/gmane.comp.version-control.git/227711/focus=227721
Also, it seems to be only part of the solution. With your change, from
contrib/mw-to-git/ and after running only "make",
./git-mw takes the installed version of GitMediawiki.pm in priority
../../bin-wrappers/git takes the installed version of git-mw only (i.e.
does not know "git mw" if "make install" hasn't been ran).
> perlcritic:
> - perlcritic -2 *.perl
> + perlcritic -2 *.perl
> \ No newline at end of file
Please, avoid these whitespace-only changes. They create noise during
review, and more potential conflicts.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2013-06-16 20:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 2:31 [PATCH V3 0/4] git-remote-mediawiki: new tool to preview local changes without pushing benoit.person
2013-06-16 2:31 ` [PATCH V3 1/4] git-mw: Introduction of GitMediawiki.pm benoit.person
2013-06-16 20:18 ` Matthieu Moy [this message]
2013-06-16 23:41 ` Benoît Person
2013-06-17 7:12 ` Matthieu Moy
2013-06-18 9:06 ` Benoît Person
2013-06-18 10:10 ` Matthieu Moy
2013-06-18 10:54 ` Matthieu Moy
2013-06-16 2:31 ` [PATCH V3 2/4] git-mw: Move some functions from git-remote-mediawiki.perl to GitMediawiki.pm benoit.person
2013-06-16 2:31 ` [PATCH V3 3/4] git-mw: Adding git-mw command benoit.person
2013-06-16 2:31 ` [PATCH V3 4/4] git-mw: Add preview subcommand into git mw benoit.person
2013-06-16 20:39 ` Matthieu Moy
2013-06-16 9:00 ` [PATCH V3 0/4] git-remote-mediawiki: new tool to preview local changes without pushing Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqobb5g679.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=benoit.person@ensimag.fr \
--cc=celestin.matte@ensimag.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).