git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: benoit.person@ensimag.fr
Cc: git@vger.kernel.org, Celestin Matte <celestin.matte@ensimag.fr>,
	Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v7 4/7] git-remote-mediawiki: Update tests to run with the new bin-wrapper
Date: Wed, 03 Jul 2013 11:18:49 +0200	[thread overview]
Message-ID: <vpqobakrog6.fsf@anie.imag.fr> (raw)
In-Reply-To: <1372804789-12732-5-git-send-email-benoit.person@ensimag.fr> (benoit person's message of "Wed, 3 Jul 2013 00:39:46 +0200")

benoit.person@ensimag.fr writes:

> --- a/contrib/mw-to-git/t/test-gitmw-lib.sh
> +++ b/contrib/mw-to-git/t/test-gitmw-lib.sh
> @@ -62,12 +62,8 @@ test_check_precond () {
>  		test_done
>  	fi
>  
> -	if [ ! -f "$GIT_BUILD_DIR"/git-remote-mediawiki ];
> -	then
> -		echo "No remote mediawiki for git found. Copying it in git"
> -		echo "cp $GIT_BUILD_DIR/contrib/mw-to-git/git-remote-mediawiki $GIT_BUILD_DIR/"
> -		ln -s "$GIT_BUILD_DIR"/contrib/mw-to-git/git-remote-mediawiki "$GIT_BUILD_DIR"
> -	fi
> +	GIT_EXEC_PATH=$(cd "$(dirname "$0")" && cd "../.." && pwd)
> +	PATH="$GIT_EXEC_PATH"'/bin-wrapper:'"$PATH"
>  
>  	if [ ! -d "$WIKI_DIR_INST/$WIKI_DIR_NAME" ];
>  	then

Cool!

I like the way adding a new feature has positive side effects on the
rest of the code.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

  reply	other threads:[~2013-07-03  9:19 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02 22:39 [PATCH v7 0/7] git-remote-mediawiki: new tool to preview local changes without pushing benoit.person
2013-07-02 22:39 ` [PATCH v7 1/7] git-remote-mediawiki: Introduction of Git::Mediawiki.pm benoit.person
2013-07-02 22:59   ` Junio C Hamano
2013-07-02 22:39 ` [PATCH v7 2/7] wrap-for-bin: Make bin-wrappers chainable benoit.person
2013-07-02 23:01   ` Junio C Hamano
2013-07-02 23:19     ` Benoît Person
2013-07-03  8:54       ` Junio C Hamano
2013-07-03  9:46         ` Benoît Person
2013-07-03 10:30   ` Michael Haggerty
2013-07-03 10:57   ` Matthieu Moy
2013-07-03 20:24     ` Junio C Hamano
2013-07-03 20:38       ` Matthieu Moy
2013-07-03 21:50         ` Junio C Hamano
2013-07-02 22:39 ` [PATCH v7 3/7] git-remote-mediawiki: New git bin-wrapper for developement benoit.person
2013-07-02 23:04   ` Junio C Hamano
2013-07-02 22:39 ` [PATCH v7 4/7] git-remote-mediawiki: Update tests to run with the new bin-wrapper benoit.person
2013-07-03  9:18   ` Matthieu Moy [this message]
2013-07-02 22:39 ` [PATCH v7 5/7] git-remote-mediawiki: Factoring code between git-remote-mediawiki and Git::Mediawiki benoit.person
2013-07-02 22:39 ` [PATCH v7 6/7] git-remote-mediawiki: Adding git-mw command benoit.person
2013-07-02 22:39 ` [PATCH v7 7/7] git-remote-mediawiki: Add preview subcommand into git mw benoit.person

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vpqobakrog6.fsf@anie.imag.fr \
    --to=matthieu.moy@grenoble-inp.fr \
    --cc=benoit.person@ensimag.fr \
    --cc=celestin.matte@ensimag.fr \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --subject='Re: [PATCH v7 4/7] git-remote-mediawiki: Update tests to run with the new bin-wrapper' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).