From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCH v7 0/11] port tag.c to use ref-filter APIs Date: Sun, 02 Aug 2015 19:32:49 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Cc: Git , Christian Couder , Junio C Hamano To: Karthik Nayak X-From: git-owner@vger.kernel.org Sun Aug 02 19:42:42 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZLxHV-0005Yq-CN for gcvg-git-2@plane.gmane.org; Sun, 02 Aug 2015 19:42:41 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751658AbbHBRmh (ORCPT ); Sun, 2 Aug 2015 13:42:37 -0400 Received: from mx2.imag.fr ([129.88.30.17]:39346 "EHLO rominette.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751904AbbHBRmg (ORCPT ); Sun, 2 Aug 2015 13:42:36 -0400 Received: from clopinette.imag.fr (clopinette.imag.fr [129.88.34.215]) by rominette.imag.fr (8.13.8/8.13.8) with ESMTP id t72HdX6Z019517 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Sun, 2 Aug 2015 19:40:08 +0200 Received: from anie.imag.fr (anie.imag.fr [129.88.7.32]) by clopinette.imag.fr (8.13.8/8.13.8) with ESMTP id t72HX1oH006768; Sun, 2 Aug 2015 19:33:16 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (rominette.imag.fr [129.88.30.17]); Sun, 02 Aug 2015 19:40:54 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: t72HdX6Z019517 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1439142054.85911@xtwR+TWthhC10zLjni+DFQ Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Karthik Nayak writes: > +test_expect_success 'no padding when `padright` length is smaller than atom length' ' > + cat >expect <<-\EOF && > + refs/heads/master| > + refs/heads/side| > + refs/odd/spot| > + refs/tags/double-tag| > + refs/tags/four| > + refs/tags/one| > + refs/tags/signed-tag| > + refs/tags/three| > + refs/tags/two| > + EOF > + git for-each-ref --format="%(padright:5)%(refname)|" >actual && > test_cmp expect actual > ' Nit: I think the test would be better with padright:15 for example, to show that some lines are aligned and some go beyond the 15 columns. -- Matthieu Moy http://www-verimag.imag.fr/~moy/