From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Johan Hovold <johan@kernel.org>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Kevin Daudt <me@ikke.info>,
Larry Finger <Larry.Finger@lwfinger.net>,
git@vger.kernel.org
Subject: Re: [PATCH v2] send-email: only allow one address per body tag
Date: Mon, 20 Feb 2017 13:10:07 +0100 [thread overview]
Message-ID: <vpqo9xxkqqo.fsf@anie.imag.fr> (raw)
In-Reply-To: <20170220114406.19436-1-johan@kernel.org> (Johan Hovold's message of "Mon, 20 Feb 2017 12:44:06 +0100")
Johan Hovold <johan@kernel.org> writes:
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1563,7 +1563,7 @@ foreach my $t (@files) {
> # Now parse the message body
> while(<$fh>) {
> $message .= $_;
> - if (/^(Signed-off-by|Cc): (.*)$/i) {
> + if (/^(Signed-off-by|Cc): ([^>]*>?)/i) {
I think this is acceptable, but this doesn't work with trailers like
Cc: "Some > Body" <Some.Body@example.com>
A proper management of this kind of weird address should be doable by
reusing the regexp parsing "..." in parse_mailbox:
my $re_quote = qr/"(?:[^\"\\]|\\.)*"/;
So the final regex would look like
if (/^(Signed-off-by|Cc): (([^>]*|"(?:[^\"\\]|\\.)*")>?)/i) {
I don't think that should block the patch inclusion, but it may be worth
considering.
Anyway, thanks for the patch!
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2017-02-20 12:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 17:49 body-CC-comment regression Johan Hovold
2017-02-16 17:59 ` Junio C Hamano
2017-02-16 18:14 ` Johan Hovold
2017-02-16 18:16 ` Matthieu Moy
2017-02-17 11:06 ` Johan Hovold
2017-02-17 13:16 ` Matthieu Moy
2017-02-17 16:42 ` Johan Hovold
2017-02-17 16:58 ` Matthieu Moy
2017-02-17 17:30 ` Johan Hovold
2017-02-17 18:18 ` Junio C Hamano
2017-02-17 18:23 ` Johan Hovold
2017-02-17 18:28 ` Junio C Hamano
2017-02-17 18:44 ` Matthieu Moy
2017-02-17 20:05 ` Junio C Hamano
2017-02-17 20:20 ` Matthieu Moy
2017-02-17 22:22 ` Junio C Hamano
2017-02-17 23:04 ` Junio C Hamano
2017-02-20 11:44 ` [PATCH v2] send-email: only allow one address per body tag Johan Hovold
2017-02-20 12:10 ` Matthieu Moy [this message]
2017-02-23 18:53 ` Junio C Hamano
2017-02-26 20:45 ` Matthieu Moy
2017-02-17 17:38 ` body-CC-comment regression Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqo9xxkqqo.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@kernel.org \
--cc=me@ikke.info \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).