From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Mathieu Lienard--Mayor <Mathieu.Lienard--Mayor@ensimag.imag.fr>,
Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>,
git@vger.kernel.org
Subject: Re: Formatting problem send_mail in version 2.10.0
Date: Thu, 13 Oct 2016 07:37:31 +0200 [thread overview]
Message-ID: <vpqmvi8n71g.fsf@anie.imag.fr> (raw)
In-Reply-To: <20161012231321.ar2csdmvhdya2q7r@sigill.intra.peff.net> (Jeff King's message of "Wed, 12 Oct 2016 19:13:22 -0400")
Jeff King <peff@peff.net> writes:
> 2. Drop everything after the trailing ">". This gives a valid rfc2822
> cc, and people can pick the "# 4.8" from the cc line in the body.
That would work for me, but it's inconsistent with Mail::Address and I'd
really like to avoid having a behavior depending on libraries installed.
Plus, consistency with Mail::Address gives us consistency with any other
program using Mail::Address.
> 3. Rewrite
>
> A <B@C> D
>
> into
>
> A D <B@C>
>
> regardless of what is in "D". This retains the information in the
> rfc2822 cc.
There's another one I considered:
4. Consider '#.*' as a comment when parsing trailers (but not in
other places where we parse addresses)
This is much harder to define properly because of
Cc: "Foo # Bar" <email@example.com>
=> we'd need to handle the ".*" syntax when stripping comments. And
again, that wouldn't be consistent with Mail::Address.
So, I ended up implementing 3., which actually isn't hard, and gives
code IMHO cleaner than it used to be.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2016-10-13 5:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 21:00 Formatting problem send_mail in version 2.10.0 Larry Finger
2016-10-10 21:48 ` Jeff King
2016-10-10 21:57 ` Jeff King
2016-10-10 23:35 ` Larry Finger
2016-10-10 23:43 ` Jeff King
2016-10-11 7:39 ` Matthieu Moy
2016-10-11 15:42 ` Larry Finger
2016-10-11 16:18 ` Matthieu Moy
2016-10-12 4:28 ` Larry Finger
2016-10-12 7:36 ` Matthieu Moy
2016-10-12 15:27 ` Larry Finger
2016-10-12 15:40 ` Matthieu Moy
2016-10-12 15:40 ` Larry Finger
2016-10-12 15:45 ` Matthieu Moy
2016-10-12 15:59 ` Larry Finger
2016-10-12 20:53 ` Junio C Hamano
2016-10-12 23:13 ` Jeff King
2016-10-13 5:37 ` Matthieu Moy [this message]
2016-10-13 5:47 ` [PATCH] parse_mailboxes: accept extra text after <...> address Matthieu Moy
2016-10-13 15:33 ` Formatting problem send_mail in version 2.10.0 Kevin Daudt
2016-10-13 16:05 ` Matthieu Moy
2016-10-13 5:32 ` Matthieu Moy
2016-10-14 17:04 ` Junio C Hamano
2016-10-11 16:02 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqmvi8n71g.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=Mathieu.Lienard--Mayor@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).