From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthieu Moy Subject: Re: [PATCH v10.1 7/7] bisect: allow any terms set by user Date: Mon, 29 Jun 2015 17:19:21 +0200 Message-ID: References: <1435351183-27100-1-git-send-email-Matthieu.Moy@imag.fr> <558F8B55.1070708@alum.mit.edu> <558F9854.5080605@alum.mit.edu> Mime-Version: 1.0 Content-Type: text/plain Cc: Michael Haggerty , Junio C Hamano , git , Antoine Delaite , Louis Stuber To: Christian Couder X-From: git-owner@vger.kernel.org Mon Jun 29 17:19:38 2015 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z9aqO-0006b7-EW for gcvg-git-2@plane.gmane.org; Mon, 29 Jun 2015 17:19:36 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752582AbbF2PTc (ORCPT ); Mon, 29 Jun 2015 11:19:32 -0400 Received: from mx1.imag.fr ([129.88.30.5]:46029 "EHLO shiva.imag.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752718AbbF2PTb (ORCPT ); Mon, 29 Jun 2015 11:19:31 -0400 Received: from clopinette.imag.fr (clopinette.imag.fr [129.88.34.215]) by shiva.imag.fr (8.13.8/8.13.8) with ESMTP id t5TFJKpo013440 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 29 Jun 2015 17:19:20 +0200 Received: from anie.imag.fr (anie.imag.fr [129.88.7.32]) by clopinette.imag.fr (8.13.8/8.13.8) with ESMTP id t5TFJLQ2031250; Mon, 29 Jun 2015 17:19:21 +0200 In-Reply-To: (Christian Couder's message of "Mon, 29 Jun 2015 12:55:26 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0.1 (shiva.imag.fr [129.88.30.5]); Mon, 29 Jun 2015 17:19:21 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: t5TFJKpo013440 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: matthieu.moy@grenoble-inp.fr MailScanner-NULL-Check: 1436195963.85679@+NbmdYdoKbfU4elX9QXnkA Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Christian Couder writes: > On Mon, Jun 29, 2015 at 11:32 AM, Matthieu Moy > wrote: >> bisect is all about finding the commit where a property has changed, > > That is your interpretation of this command. On the man page there is: > > git-bisect - Find by binary search the change that introduced a bug > > So its stated purpose is to find the first "bad" commit. Not to find a fix. This is a limitation of the current bisect, but the discussion is precisely about removing this limitation. I still don't understand what "risk" we are taking by doing the bisection anyway. I can't imagine a case where we would harm the user by doing so. I just tested with Mercurial, and looking for a fix instead of a regression just works: $ hg bisect --good 4 $ hg bisect --bad 1 Testing changeset 2:d75a2d042c99 (3 changesets remaining, ~1 tests) 1 files updated, 0 files merged, 0 files removed, 0 files unresolved $ hg bisect --bad Testing changeset 3:9d27d9c02e28 (2 changesets remaining, ~1 tests) 1 files updated, 0 files merged, 0 files removed, 0 files unresolved $ hg bisect --bad The first good revision is: changeset: 4:1dd9bb959eb6 tag: tip user: Matthieu Moy date: Mon Jun 29 17:07:51 2015 +0200 summary: foo I don't see anything wrong with this. (OTOH, "hg bisect" does not accept revisions which aren't parent of each other) -- Matthieu Moy http://www-verimag.imag.fr/~moy/