From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Paul Tan <pyokagan@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] enter_repo(): fix suffix precedence documentation
Date: Mon, 30 Mar 2015 13:08:41 +0200 [thread overview]
Message-ID: <vpqk2xykaiu.fsf@anie.imag.fr> (raw)
In-Reply-To: <1427711433-3104-1-git-send-email-pyokagan@gmail.com> (Paul Tan's message of "Mon, 30 Mar 2015 18:30:33 +0800")
Paul Tan <pyokagan@gmail.com> writes:
> The ordering of the list of suffixes tested in enter_repo() is
> documented as "%s.git/.git", "%s/.git", "%s.git", "%s". This does not
> match the ordering of the list of suffixes tested in the code which is
> "%s/.git", "%s", "%s.git/.git", "%s.git". Fix this.
Indeed:
static const char *suffix[] = {
"/.git", "", ".git/.git", ".git", NULL,
};
So the patch is clearly good. Thanks,
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-03-30 11:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 10:30 [PATCH] enter_repo(): fix suffix precedence documentation Paul Tan
2015-03-30 11:08 ` Matthieu Moy [this message]
2015-03-31 13:39 ` [PATCH v2] enter_repo(): fix docs to match code Paul Tan
2015-03-31 17:35 ` Junio C Hamano
2015-03-31 17:41 ` Jeff King
2015-03-31 17:57 ` Junio C Hamano
2015-03-31 18:10 ` [PATCH v3] " Paul Tan
2015-03-30 11:44 ` [PATCH] enter_repo(): fix suffix precedence documentation Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpqk2xykaiu.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=pyokagan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).